From 56b9245b1a429502c3f3e9d1576dbaffac5d6c0c Mon Sep 17 00:00:00 2001 From: Hixie Date: Tue, 17 Nov 2015 11:08:46 -0800 Subject: [PATCH] Allowing us to have a single error seems silly. --- packages/flutter/lib/src/widgets/basic.dart | 2 ++ packages/flutter_tools/lib/src/commands/analyze.dart | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/flutter/lib/src/widgets/basic.dart b/packages/flutter/lib/src/widgets/basic.dart index 1398d02bf21..7989cc93648 100644 --- a/packages/flutter/lib/src/widgets/basic.dart +++ b/packages/flutter/lib/src/widgets/basic.dart @@ -749,6 +749,8 @@ class Positioned extends ParentDataWidget { top = rect.top, width = rect.width, height = rect.height, + right = null, + bottom = null, super(key: key, child: child); final double top; diff --git a/packages/flutter_tools/lib/src/commands/analyze.dart b/packages/flutter_tools/lib/src/commands/analyze.dart index 519216c1c53..53e1b6aa545 100644 --- a/packages/flutter_tools/lib/src/commands/analyze.dart +++ b/packages/flutter_tools/lib/src/commands/analyze.dart @@ -289,10 +289,10 @@ class AnalyzeCommand extends FlutterCommand { } } - if (exitCode < 0 || exitCode > 3) // 1 = hints, 2 = warnings, 3 = errors + if (exitCode < 0 || exitCode > 3) // 0 = nothing, 1 = hints, 2 = warnings, 3 = errors return exitCode; - if (errorCount > 1) + if (errorCount > 0) return 1; if (argResults['congratulate']) print('No analyzer warnings!');