DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Move lint suppression from baseline.xml to @SuppressLint. (flutter/engine#55447)

Browse Source 
I think you just had the lint identifier wrong?

Closes https://github.com/flutter/flutter/issues/155712.
This commit is contained in:
Matan Lurey 2024-09-25 15:41:11 -07:00 committed by GitHub
parent 152dfb2fcf
commit e89480f02d
2 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java
View File

@ -683,7 +683,7 @@ public class FlutterView extends FrameLayout
// The annotations to suppress "InlinedApi" and "NewApi" lints prevent lint warnings
// caused by usage of Android Q APIs. These calls are safe because they are
// guarded.
@SuppressLint({"InlinedApi", "NewApi"})
@SuppressLint({"InlinedApi", "NewApi", "DeprecatedSinceApi"})
@NonNull
public final WindowInsets onApplyWindowInsets(@NonNull WindowInsets insets) {
WindowInsets newInsets = super.onApplyWindowInsets(insets);

11
engine/src/flutter/tools/android_lint/baseline.xml
View File

@ -1,17 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.3.0 [11479570] " type="baseline" client="" dependencies="true" name="" variant="all" version="8.3.0 [11479570] ">
<issue
id="DeprecatedSinceApi"
message="This method is deprecated as of API level 30"
errorLine1=" zeroSides = calculateShouldZeroSides();"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="../../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java"
line="759"
column="21"/>
</issue>
<issue
id="HardcodedDebugMode"
message="Avoid hardcoding the debug mode; leaving it out allows debug and release builds to automatically assign one"