From e59951fa155fc8faf35a54c353e61d87abcdcc75 Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Tue, 21 May 2019 12:39:11 -0700 Subject: [PATCH] Avoid unnecessary copying of vectors in AccessibilityBridge (flutter/engine#9033) --- .../darwin/ios/framework/Source/accessibility_bridge.mm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm index 1409b298e1f..2dcb7384c66 100644 --- a/engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm +++ b/engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm @@ -198,7 +198,7 @@ flutter::SemanticsAction GetSemanticsActionForScrollDirection( args.push_back(action_id >> 16); args.push_back(action_id >> 24); [self bridge] -> DispatchSemanticsAction([self uid], flutter::SemanticsAction::kCustomAction, - args); + std::move(args)); return YES; } @@ -689,14 +689,13 @@ void AccessibilityBridge::UpdateSemantics(flutter::SemanticsNodeUpdates nodes, } void AccessibilityBridge::DispatchSemanticsAction(int32_t uid, flutter::SemanticsAction action) { - std::vector args; - platform_view_->DispatchSemanticsAction(uid, action, args); + platform_view_->DispatchSemanticsAction(uid, action, {}); } void AccessibilityBridge::DispatchSemanticsAction(int32_t uid, flutter::SemanticsAction action, std::vector args) { - platform_view_->DispatchSemanticsAction(uid, action, args); + platform_view_->DispatchSemanticsAction(uid, action, std::move(args)); } SemanticsObject* AccessibilityBridge::GetOrCreateObject(int32_t uid,