diff --git a/.ci.yaml b/.ci.yaml index ab911153014..4bbe997c9ee 100755 --- a/.ci.yaml +++ b/.ci.yaml @@ -382,7 +382,7 @@ targets: - packages/fuchsia_remote_debug_protocol/ - packages/flutter_test/ - packages/flutter_goldens/ - - packages/flutter_tools/lib/src/test/ + - packages/flutter_tools/ - bin/ - .ci.yaml @@ -413,7 +413,7 @@ targets: - packages/fuchsia_remote_debug_protocol/ - packages/flutter_test/ - packages/flutter_goldens/ - - packages/flutter_tools/lib/src/test/ + - packages/flutter_tools/ - bin/ - .ci.yaml @@ -439,7 +439,7 @@ targets: - packages/fuchsia_remote_debug_protocol/ - packages/flutter_test/ - packages/flutter_goldens/ - - packages/flutter_tools/lib/src/test/ + - packages/flutter_tools/ - bin/ - .ci.yaml @@ -2491,7 +2491,7 @@ targets: - packages/fuchsia_remote_debug_protocol/** - packages/flutter_test/** - packages/flutter_goldens/** - - packages/flutter_tools/lib/src/test/** + - packages/flutter_tools/** - bin/** - .ci.yaml @@ -2521,7 +2521,7 @@ targets: - packages/fuchsia_remote_debug_protocol/** - packages/flutter_test/** - packages/flutter_goldens/** - - packages/flutter_tools/lib/src/test/** + - packages/flutter_tools/** - bin/** - .ci.yaml @@ -2547,7 +2547,7 @@ targets: - packages/fuchsia_remote_debug_protocol/** - packages/flutter_test/** - packages/flutter_goldens/** - - packages/flutter_tools/lib/src/test/** + - packages/flutter_tools/** - bin/** - .ci.yaml @@ -3663,7 +3663,7 @@ targets: - packages/fuchsia_remote_debug_protocol/ - packages/flutter_test/ - packages/flutter_goldens/ - - packages/flutter_tools/lib/src/test/ + - packages/flutter_tools/ - bin/ - .ci.yaml @@ -3692,7 +3692,7 @@ targets: - packages/fuchsia_remote_debug_protocol/ - packages/flutter_test/ - packages/flutter_goldens/ - - packages/flutter_tools/lib/src/test/ + - packages/flutter_tools/ - bin/ - .ci.yaml @@ -3718,7 +3718,7 @@ targets: - packages/fuchsia_remote_debug_protocol/ - packages/flutter_test/ - packages/flutter_goldens/ - - packages/flutter_tools/lib/src/test/ + - packages/flutter_tools/ - bin/ - .ci.yaml diff --git a/dev/conductor/core/lib/src/codesign.dart b/dev/conductor/core/lib/src/codesign.dart index 8fa00992c9b..337a66f3b9b 100644 --- a/dev/conductor/core/lib/src/codesign.dart +++ b/dev/conductor/core/lib/src/codesign.dart @@ -143,9 +143,15 @@ class CodesignCommand extends Command { 'artifacts/engine/android-x64-profile/darwin-x64/gen_snapshot', 'artifacts/engine/android-x64-release/darwin-x64/gen_snapshot', 'artifacts/engine/darwin-x64-profile/gen_snapshot', + 'artifacts/engine/darwin-x64-profile/gen_snapshot_arm64', + 'artifacts/engine/darwin-x64-profile/gen_snapshot_x64', 'artifacts/engine/darwin-x64-release/gen_snapshot', + 'artifacts/engine/darwin-x64-release/gen_snapshot_arm64', + 'artifacts/engine/darwin-x64-release/gen_snapshot_x64', 'artifacts/engine/darwin-x64/flutter_tester', 'artifacts/engine/darwin-x64/gen_snapshot', + 'artifacts/engine/darwin-x64/gen_snapshot_arm64', + 'artifacts/engine/darwin-x64/gen_snapshot_x64', 'artifacts/engine/ios-profile/gen_snapshot_arm64', 'artifacts/engine/ios-profile/gen_snapshot_armv7', 'artifacts/engine/ios-release/gen_snapshot_arm64', diff --git a/packages/flutter_tools/lib/src/flutter_cache.dart b/packages/flutter_tools/lib/src/flutter_cache.dart index dd8468c809d..eb1015cd496 100644 --- a/packages/flutter_tools/lib/src/flutter_cache.dart +++ b/packages/flutter_tools/lib/src/flutter_cache.dart @@ -870,10 +870,13 @@ const List> _windowsUwpDesktopBinaryDirs = >[ const List> _macOSDesktopBinaryDirs = >[ ['darwin-x64', 'darwin-x64/FlutterMacOS.framework.zip'], + ['darwin-x64', 'darwin-x64/gen_snapshot.zip'], ['darwin-x64-profile', 'darwin-x64-profile/FlutterMacOS.framework.zip'], ['darwin-x64-profile', 'darwin-x64-profile/artifacts.zip'], + ['darwin-x64-profile', 'darwin-x64-profile/gen_snapshot.zip'], ['darwin-x64-release', 'darwin-x64-release/FlutterMacOS.framework.zip'], ['darwin-x64-release', 'darwin-x64-release/artifacts.zip'], + ['darwin-x64-release', 'darwin-x64-release/gen_snapshot.zip'], ]; const List> _osxBinaryDirs = >[ diff --git a/packages/flutter_tools/test/general.shard/cache_test.dart b/packages/flutter_tools/test/general.shard/cache_test.dart index 849d9398658..003f7301b0d 100644 --- a/packages/flutter_tools/test/general.shard/cache_test.dart +++ b/packages/flutter_tools/test/general.shard/cache_test.dart @@ -557,6 +557,19 @@ void main() { ]); }); + testWithoutContext('macOS desktop artifacts include all gen_snapshot binaries', () { + final Cache cache = Cache.test(processManager: FakeProcessManager.any()); + final MacOSEngineArtifacts artifacts = MacOSEngineArtifacts(cache, platform: FakePlatform()); + cache.includeAllPlatforms = false; + cache.platformOverrideArtifacts = {'macos'}; + + expect(artifacts.getBinaryDirs(), containsAll(>[ + ['darwin-x64', 'darwin-x64/gen_snapshot.zip'], + ['darwin-x64-profile', 'darwin-x64-profile/gen_snapshot.zip'], + ['darwin-x64-release', 'darwin-x64-release/gen_snapshot.zip'], + ])); + }); + testWithoutContext('macOS desktop artifacts ignore filtering when requested', () { final Cache cache = Cache.test(processManager: FakeProcessManager.any()); final MacOSEngineArtifacts artifacts = MacOSEngineArtifacts(cache, platform: FakePlatform());