DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] handle fill polylines with zero area. (flutter/engine#51945)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/146362

Sometimes we can have effectively zero area in a way that doesn't seem to register with the Skia bounding box logic we're using. Add a sanity check for zero points in the polyline.
This commit is contained in:
Jonah Williams 2024-04-05 14:10:18 -07:00 committed by GitHub
parent 5440d99e97
commit e2e64c5901
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/src/flutter/impeller/tessellator/tessellator.cc
View File

@ -187,6 +187,9 @@ std::vector<Point> Tessellator::TessellateConvex(const Path& path,
[this](Path::Polyline::PointBufferPtr point_buffer) {
point_buffer_ = std::move(point_buffer);
});
if (polyline.points->size() == 0) {
return output;
}
output.reserve(polyline.points->size() +
(4 * (polyline.contours.size() - 1)));

13
engine/src/flutter/impeller/tessellator/tessellator_unittests.cc
View File

@ -480,6 +480,19 @@ TEST(TessellatorTest, FilledRoundRectTessellationVertices) {
Rect::MakeXYWH(5000, 10000, 2000, 3000), {50, 70});
}
TEST(TessellatorTest, EarlyReturnEmptyConvexShape) {
// This path is not technically empty (it has a size in one dimension),
// but is otherwise completely flat.
auto tessellator = std::make_shared<Tessellator>();
PathBuilder builder;
builder.MoveTo({0, 0});
builder.MoveTo({10, 10}, /*relative=*/true);
auto points = tessellator->TessellateConvex(builder.TakePath(), 3.0);
EXPECT_TRUE(points.empty());
}
#if !NDEBUG
TEST(TessellatorTest, ChecksConcurrentPolylineUsage) {
auto tessellator = std::make_shared<Tessellator>();