DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Avoid race condition into NotifyNextFrameOnce (flutter/engine#3980)

Browse Source 
If GPURasterizer::NotifyNextFrameOnce was rapidly invoked twice could
have lead to a null pointer exception.

Also ftp::WeakPtr are not thread safe and should not be dereferenced
from other threads.
This commit is contained in:
Carlo Bernaschina 2017-08-15 14:35:16 -07:00 committed by GitHub
parent 05dd4a01dd
commit e2b8d9e76b
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
engine/src/flutter/shell/gpu/gpu_rasterizer.cc
View File

@ -148,14 +148,11 @@ void GPURasterizer::AddNextFrameCallback(ftl::Closure nextFrameCallback) {
void GPURasterizer::NotifyNextFrameOnce() {
if (nextFrameCallback_) {
blink::Threads::Platform()->PostTask([weak_this = weak_factory_.GetWeakPtr()] {
blink::Threads::Platform()->PostTask([callback = nextFrameCallback_] {
TRACE_EVENT0("flutter", "GPURasterizer::NotifyNextFrameOnce");
if (weak_this) {
ftl::Closure callback = weak_this->nextFrameCallback_;
callback();
weak_this->nextFrameCallback_ = nullptr;
}
callback();
});
nextFrameCallback_ = nullptr;
}
}