From e2a2a79a1dc06efa34bd3c8bfcfe11115c3ca80c Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Wed, 10 Mar 2021 10:26:49 -0800 Subject: [PATCH] Add framebuffer destruction_callback for Linux (flutter/engine#24901) While we no longer crash when the framebuffer destruction_callback is null (patched in https://github.com/flutter/engine/pull/24845) we should bet setting one, even if it's a no-op containing a comment pointing to where cleanup is implemented. --- engine/src/flutter/shell/platform/linux/fl_renderer_gl.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/engine/src/flutter/shell/platform/linux/fl_renderer_gl.cc b/engine/src/flutter/shell/platform/linux/fl_renderer_gl.cc index 09be16586db..9a657f290f4 100644 --- a/engine/src/flutter/shell/platform/linux/fl_renderer_gl.cc +++ b/engine/src/flutter/shell/platform/linux/fl_renderer_gl.cc @@ -61,6 +61,10 @@ static gboolean fl_renderer_gl_create_backing_store( backing_store_out->open_gl.framebuffer.user_data = provider; backing_store_out->open_gl.framebuffer.name = name; backing_store_out->open_gl.framebuffer.target = format; + backing_store_out->open_gl.framebuffer.destruction_callback = [](void* p) { + // Backing store destroyed in fl_renderer_gl_collect_backing_store(), set + // on FlutterCompositor.collect_backing_store_callback during engine start. + }; return TRUE; }