From e093aa3658e79deff4a992d85452497e5013abc7 Mon Sep 17 00:00:00 2001 From: Konstantin Scheglov Date: Thu, 10 Apr 2025 10:50:57 -0700 Subject: [PATCH] Remove unnecessary this. qualifiers. (#166805) I'm fixing a bug in a lint, and fixing existing violations. https://dart-review.googlesource.com/c/sdk/+/421421 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- packages/flutter/lib/src/cupertino/route.dart | 2 +- packages/flutter/lib/src/widgets/routes.dart | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/flutter/lib/src/cupertino/route.dart b/packages/flutter/lib/src/cupertino/route.dart index fdfe92b0742..60ece8f8798 100644 --- a/packages/flutter/lib/src/cupertino/route.dart +++ b/packages/flutter/lib/src/cupertino/route.dart @@ -345,7 +345,7 @@ class _PageBasedCupertinoPageRoute extends PageRoute with CupertinoRouteTr @override DelegatedTransitionBuilder? get delegatedTransition => - this.fullscreenDialog ? null : CupertinoPageTransition.delegatedTransition; + fullscreenDialog ? null : CupertinoPageTransition.delegatedTransition; CupertinoPage get _page => settings as CupertinoPage; diff --git a/packages/flutter/lib/src/widgets/routes.dart b/packages/flutter/lib/src/widgets/routes.dart index f873ee588b4..9e4b44755f6 100644 --- a/packages/flutter/lib/src/widgets/routes.dart +++ b/packages/flutter/lib/src/widgets/routes.dart @@ -2134,7 +2134,7 @@ abstract class ModalRoute extends TransitionRoute with LocalHistoryRoute? nextRoute) { if (nextRoute is ModalRoute && canTransitionTo(nextRoute) && - nextRoute.delegatedTransition != this.delegatedTransition) { + nextRoute.delegatedTransition != delegatedTransition) { receivedTransition = nextRoute.delegatedTransition; } else { receivedTransition = null; @@ -2147,7 +2147,7 @@ abstract class ModalRoute extends TransitionRoute with LocalHistoryRoute nextRoute) { if (nextRoute is ModalRoute && canTransitionTo(nextRoute) && - nextRoute.delegatedTransition != this.delegatedTransition) { + nextRoute.delegatedTransition != delegatedTransition) { receivedTransition = nextRoute.delegatedTransition; } else { receivedTransition = null;