DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

AX fixes for iOS (flutter/engine#3700)

Browse Source 
* AX fixes for iOS

With this, the accessibility frame (for VoiceOver, etc.) is drawn at the right position around a widget.

* review comments
This commit is contained in:
Michael Goderbauer 2017-05-19 10:22:56 -07:00 committed by GitHub
parent 819a40bc22
commit e063effa8e
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
engine/src/flutter/shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm
View File

@ -113,7 +113,7 @@ blink::SemanticsAction GetSemanticsActionForScrollDirection(
- (CGRect)accessibilityFrame {
SkMatrix44 globalTransform = _node.transform;
for (SemanticsObject* parent = _parent; parent; parent = parent.parent) {
globalTransform = globalTransform * parent->_node.transform;
globalTransform = parent->_node.transform * globalTransform;
}
SkPoint quad[4];
@ -126,7 +126,12 @@ blink::SemanticsAction GetSemanticsActionForScrollDirection(
SkRect rect;
rect.set(quad, 4);
auto result = CGRectMake(rect.x(), rect.y(), rect.width(), rect.height());
// `rect` is in the physical pixel coordinate system. iOS expects the accessibility frame in
// the logical pixel coordinate system. Therefore, we divide by the `scale` (pixel ratio) to
// convert.
CGFloat scale = [[_bridge->view() window] screen].scale;
auto result =
CGRectMake(rect.x() / scale, rect.y() / scale, rect.width() / scale, rect.height() / scale);
return UIAccessibilityConvertFrameToScreenCoordinates(result, _bridge->view());
}