DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add clear() to Element.classList.

Browse Source 
We should support a fast way to remove all classes through the
classList instead of having to call removeAttribute() directly.

BUG=440529
R=ojan@chromium.org, rafaelw@chromium.org

Review URL: https://codereview.chromium.org/788093003
This commit is contained in:
Elliott Sprehn 2014-12-09 17:56:41 -08:00
parent c2916617b4
commit dfd9a3faa5
5 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
engine/core/dom/DOMTokenList.cpp
View File

@ -83,6 +83,11 @@ void DOMTokenList::setValue(const AtomicString& value)
m_element->setAttribute(HTMLNames::classAttr, value);
}
void DOMTokenList::clear()
{
m_element->removeAttribute(HTMLNames::classAttr);
}
bool DOMTokenList::validateToken(const String& token, ExceptionState& exceptionState)
{
if (token.isEmpty()) {

1
engine/core/dom/DOMTokenList.h
View File

@ -62,6 +62,7 @@ public:
void remove(const AtomicString&, ExceptionState&);
bool toggle(const AtomicString&, ExceptionState&);
bool toggle(const AtomicString&, bool force, ExceptionState&);
void clear();
const AtomicString& toString() const { return value(); }

2
engine/core/dom/DOMTokenList.idl
View File

@ -32,6 +32,8 @@
[RaisesException, CustomElementCallbacks] void remove(DOMString... tokens);
[RaisesException, CustomElementCallbacks] boolean toggle(DOMString token, optional boolean force);
void clear();
[NotEnumerable] stringifier;
};

15
tests/lowlevel/classlist-expected.txt
View File

@ -1,12 +1,13 @@
Running 8 tests
Running 9 tests
ok 1 Class list should add multiple classes
ok 2 Class list should add classes in order
ok 3 Class list should remove classes
ok 4 Class list should remove multiple classes
ok 5 Class list should check for classes
ok 6 Class list should get classes by index
ok 7 Class list should toggle classes
ok 8 Class list should dynamically update style
8 tests
8 pass
ok 5 Class list should clear all classes
ok 6 Class list should check for classes
ok 7 Class list should get classes by index
ok 8 Class list should toggle classes
ok 9 Class list should dynamically update style
9 tests
9 pass
0 fail

8
tests/lowlevel/classlist.sky
View File

@ -48,6 +48,14 @@ describe("Class list", function() {
assert.equal(target.classList.toString(), "second");
});
it("should clear all classes", function() {
target.classList.add("first");
target.classList.add("second");
target.classList.clear();
assert.equal(target.classList.toString(), "");
assert.isFalse(target.hasAttribute("class"));
});
it("should check for classes", function() {
target.classList.add("first", "second", "third");
assert.isTrue(target.classList.contains("first"));