DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-14 14:50:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixing local golden output flake (#44307)

Browse Source
This commit is contained in:
Kate Lovett 2019-11-07 13:01:32 -08:00 committed by GitHub
parent 3dd6741078
commit dfbbfcd390
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/flutter_goldens/lib/flutter_goldens.dart
View File

@ -506,10 +506,11 @@ class FlutterLocalFileComparator extends FlutterGoldenFileComparator with LocalC
}
failureDiffs[expectation] = result;
}
failureDiffs.forEach((String expectation, ComparisonResult result) async {
if (await skiaClient.isValidDigestForExpectation(expectation, golden.path))
generateFailureOutput(result, golden, basedir, key: expectation);
});
for (MapEntry<String, ComparisonResult> entry in failureDiffs.entries) {
if (await skiaClient.isValidDigestForExpectation(entry.key, golden.path))
generateFailureOutput(entry.value, golden, basedir, key: entry.key);
}
return false;
}
}

21
packages/flutter_goldens/test/flutter_goldens_test.dart
View File

@ -741,6 +741,27 @@ void main() {
isTrue,
);
});
test('compare properly awaits validation & output before failing.', () async {
final Completer<bool> completer = Completer<bool>();
when(mockSkiaClient.isValidDigestForExpectation(
'55109a4bed52acc780530f7a9aeff6c0',
'library.flutter.golden_test.1.png',
))
.thenAnswer((_) => completer.future);
final Future<bool> result = comparator.compare(
Uint8List.fromList(_kFailPngBytes),
Uri.parse('flutter.golden_test.1.png'),
);
bool shouldThrow = true;
result.then((_) {
if (shouldThrow)
fail('Compare completed before validation completed!');
});
await Future<void>.value();
shouldThrow = false;
completer.complete(Future<bool>.value(false));
});
});
});
}