DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disallow negative padding and margins

Browse Source 
They're just as crazy in this system as they are in the web.
This commit is contained in:
Adam Barth 2015-09-04 12:25:26 -07:00
parent 4840f80242
commit dfb89fee8c
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sky/packages/sky/lib/painting/box_painter.dart
View File

@ -45,6 +45,8 @@ class EdgeDims {
/// The offset from the left
final double left;
bool get isNonNegative => top >= 0.0 && right >= 0.0 && bottom >= 0.0 && left >= 0.0;
bool operator ==(other) {
if (identical(this, other))
return true;

1
sky/packages/sky/lib/src/rendering/shifted_box.dart
View File

@ -79,6 +79,7 @@ class RenderPadding extends RenderShiftedBox {
EdgeDims get padding => _padding;
void set padding (EdgeDims value) {
assert(value != null);
assert(value.isNonNegative);
if (_padding == value)
return;
_padding = value;

5
sky/packages/sky/lib/src/widgets/basic.dart
View File

@ -393,7 +393,10 @@ class Container extends Component {
this.margin,
this.padding,
this.transform
}) : super(key: key);
}) : super(key: key) {
assert(margin == null || margin.isNonNegative);
assert(padding == null || padding.isNonNegative);
}
final Widget child;
final BoxConstraints constraints;