From de7c02c2cb49e8f1925c0b01aa5ab38f05bbca25 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Wed, 10 May 2023 16:03:58 -0700 Subject: [PATCH] [macos] Disable background colour tests (flutter/engine#41904) These tests are flaky. Until they've been deflaked, disable the following two tests: * FlutterEngineTest.BackgroundIsBlack * FlutterEngineTest.CanOverrideBackgroundColor Issue: https://github.com/flutter/flutter/issues/124677 --- .../darwin/macos/framework/Source/FlutterEngineTest.mm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm b/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm index d7aa813ca2f..92e87100dd0 100644 --- a/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm +++ b/engine/src/flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm @@ -134,7 +134,8 @@ TEST_F(FlutterEngineTest, CanLogToStdout) { EXPECT_TRUE(logs.find("Hello logging") != std::string::npos); } -TEST_F(FlutterEngineTest, BackgroundIsBlack) { +// TODO(cbracken): Needs deflaking. https://github.com/flutter/flutter/issues/124677 +TEST_F(FlutterEngineTest, DISABLED_BackgroundIsBlack) { FlutterEngine* engine = GetFlutterEngine(); // Latch to ensure the entire layer tree has been generated and presented. @@ -163,7 +164,8 @@ TEST_F(FlutterEngineTest, BackgroundIsBlack) { latch.Wait(); } -TEST_F(FlutterEngineTest, CanOverrideBackgroundColor) { +// TODO(cbracken): Needs deflaking. https://github.com/flutter/flutter/issues/124677 +TEST_F(FlutterEngineTest, DISABLED_CanOverrideBackgroundColor) { FlutterEngine* engine = GetFlutterEngine(); // Latch to ensure the entire layer tree has been generated and presented.