From dadea111907417925c4b00a12ad0197c7045f93c Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Mon, 14 Nov 2022 13:25:03 -0800 Subject: [PATCH] [Impeller] error earlier on uint types (flutter/engine#37593) --- engine/src/flutter/impeller/compiler/spirv_sksl.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/engine/src/flutter/impeller/compiler/spirv_sksl.cc b/engine/src/flutter/impeller/compiler/spirv_sksl.cc index 2535d4ec6e6..643f90e8d1d 100644 --- a/engine/src/flutter/impeller/compiler/spirv_sksl.cc +++ b/engine/src/flutter/impeller/compiler/spirv_sksl.cc @@ -118,6 +118,11 @@ void CompilerSkSL::emit_header() { void CompilerSkSL::emit_uniform(const SPIRVariable& var) { auto& type = get(var.basetype); + if (type.basetype == SPIRType::UInt && is_legacy()) { + FLUTTER_CROSS_THROW("SkSL does not support unsigned integers: '" + + get_name(var.self) + "'"); + } + add_resource_name(var.self); statement(variable_decl(var), ";");