From daa1bbbed7b0503f395ce1b3952eeff504dcb159 Mon Sep 17 00:00:00 2001 From: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Date: Mon, 18 Nov 2024 10:08:02 -0800 Subject: [PATCH] Started only loading gles3 functions if we have a gles3 context (flutter/engine#56636) test: exists in https://github.com/flutter/engine/pull/56596 fixes: https://github.com/flutter/flutter/issues/158995 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style --- .../impeller/renderer/backend/gles/proc_table_gles.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/engine/src/flutter/impeller/renderer/backend/gles/proc_table_gles.cc b/engine/src/flutter/impeller/renderer/backend/gles/proc_table_gles.cc index ee4af806d24..172fb245b54 100644 --- a/engine/src/flutter/impeller/renderer/backend/gles/proc_table_gles.cc +++ b/engine/src/flutter/impeller/renderer/backend/gles/proc_table_gles.cc @@ -121,7 +121,11 @@ ProcTableGLES::ProcTableGLES( // NOLINT(google-readability-function-size) reinterpret_cast(fn_ptr); \ proc_ivar.error_fn = error_fn; \ } - FOR_EACH_IMPELLER_GLES3_PROC(IMPELLER_PROC); + + if (description_->GetGlVersion().IsAtLeast(Version(3))) { + FOR_EACH_IMPELLER_GLES3_PROC(IMPELLER_PROC); + } + FOR_EACH_IMPELLER_EXT_PROC(IMPELLER_PROC); #undef IMPELLER_PROC