DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Enable the silent flag for invalid string exceptions when building a TextSpan (#138564)

Browse Source 
This error can occur in a release app (for example, if the text comes from user input that is not valid UTF-16).  In that case, TextSpan will replace the invalid text with a placeholder character.
This commit is contained in:
Jason Simmons 2023-11-16 13:55:26 -08:00 committed by GitHub
parent 61d3710500
commit d859865e34
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/flutter/lib/src/painting/text_span.dart
View File

@ -285,6 +285,7 @@ class TextSpan extends InlineSpan implements HitTestTarget, MouseTrackerAnnotati
stack: stack,
library: 'painting library',
context: ErrorDescription('while building a TextSpan'),
silent: true,
));
// Use a Unicode replacement character as a substitute for invalid text.
builder.addText('\uFFFD');

7
packages/flutter/test/painting/text_painter_test.dart
View File

@ -1193,9 +1193,9 @@ void main() {
}, skip: isBrowser && !isCanvasKit); // https://github.com/flutter/flutter/issues/87543
test('TextPainter handles invalid UTF-16', () {
Object? exception;
FlutterErrorDetails? error;
FlutterError.onError = (FlutterErrorDetails details) {
exception = details.exception;
error = details;
};
final TextPainter painter = TextPainter()
@ -1207,7 +1207,8 @@ void main() {
painter.layout();
// The layout should include one replacement character.
expect(painter.width, equals(fontSize));
expect(exception, isNotNull);
expect(error!.exception, isNotNull);
expect(error!.silent, isTrue);
painter.dispose();
}, skip: kIsWeb); // https://github.com/flutter/flutter/issues/87544