From d8571fda68cd0098ec58ad8cea3eb65856ce15e7 Mon Sep 17 00:00:00 2001 From: Gray Mackall <34871572+gmackall@users.noreply.github.com> Date: Fri, 9 May 2025 13:37:05 -0700 Subject: [PATCH] Remove old link for java gradle incompatibility (#168561) We don't need this link anymore, and the current instructions already tell users what to do. Fixes https://github.com/flutter/website/issues/11530 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md Co-authored-by: Gray Mackall --- packages/flutter_tools/lib/src/android/gradle_errors.dart | 4 +--- .../test/general.shard/android/gradle_errors_test.dart | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/flutter_tools/lib/src/android/gradle_errors.dart b/packages/flutter_tools/lib/src/android/gradle_errors.dart index 0a750c24fee..55e4d8693dd 100644 --- a/packages/flutter_tools/lib/src/android/gradle_errors.dart +++ b/packages/flutter_tools/lib/src/android/gradle_errors.dart @@ -578,9 +578,7 @@ final GradleHandledError incompatibleJavaAndGradleVersionsHandler = GradleHandle globals.printBox( "${globals.logger.terminal.warningMark} Your project's Gradle version " 'is incompatible with the Java version that Flutter is using for Gradle.\n\n' - 'If you recently upgraded Android Studio, consult the migration guide ' - 'at https://flutter.dev/to/java-gradle-incompatibility.\n\n' - 'Otherwise, to fix this issue, first, check the Java version used by Flutter by ' + 'To fix this issue, first, check the Java version used by Flutter by ' 'running `flutter doctor --verbose`.\n\n' 'Then, update the Gradle version specified in ${gradlePropertiesFile.path} ' 'to be compatible with that Java version. ' diff --git a/packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart b/packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart index ebbac38fe55..a191a26d9c2 100644 --- a/packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart +++ b/packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart @@ -1351,7 +1351,6 @@ Could not compile build file '…/example/android/build.gradle'. testLogger.statusText, contains('Gradle version is incompatible with the Java version'), ); - expect(testLogger.statusText, contains('flutter.dev/to/java-gradle-incompatibility')); expect(testLogger.statusText, contains('gradle-wrapper.properties')); expect( testLogger.statusText,