From d83fa696c0a57531a306cf31cf894b3e6daedaf1 Mon Sep 17 00:00:00 2001 From: Qun Cheng Date: Wed, 20 Nov 2024 16:59:19 -0800 Subject: [PATCH] Revert partial unit tests in page_transitions_theme_test.dart --- .../material/page_transitions_theme_test.dart | 23 ++++++++++++++----- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/packages/flutter/test/material/page_transitions_theme_test.dart b/packages/flutter/test/material/page_transitions_theme_test.dart index a760a8b0f64..87cf016c70f 100644 --- a/packages/flutter/test/material/page_transitions_theme_test.dart +++ b/packages/flutter/test/material/page_transitions_theme_test.dart @@ -64,7 +64,7 @@ void main() { expect(find.byType(CupertinoPageTransition), findsOneWidget); }, variant: const TargetPlatformVariant({ TargetPlatform.iOS, TargetPlatform.macOS })); - testWidgets('Default PageTransitionsTheme builds a _FadeForwardsPageTransition for android', (WidgetTester tester) async { + testWidgets('Default PageTransitionsTheme builds a _ZoomPageTransition for android', (WidgetTester tester) async { final Map routes = { '/': (BuildContext context) => Material( child: TextButton( @@ -81,20 +81,20 @@ void main() { ), ); - Finder findFadeForwardsPageTransition() { + Finder findZoomPageTransition() { return find.descendant( of: find.byType(MaterialApp), - matching: find.byWidgetPredicate((Widget w) => '${w.runtimeType}' == '_FadeForwardsPageTransition'), + matching: find.byWidgetPredicate((Widget w) => '${w.runtimeType}' == '_ZoomPageTransition'), ); } expect(Theme.of(tester.element(find.text('push'))).platform, debugDefaultTargetPlatformOverride); - expect(findFadeForwardsPageTransition(), findsOneWidget); + expect(findZoomPageTransition(), findsOneWidget); await tester.tap(find.text('push')); await tester.pumpAndSettle(); expect(find.text('page b'), findsOneWidget); - expect(findFadeForwardsPageTransition(), findsOneWidget); + expect(findZoomPageTransition(), findsOneWidget); }, variant: TargetPlatformVariant.only(TargetPlatform.android)); testWidgets('Default background color when FadeForwardsPageTransitionBuilder is used', (WidgetTester tester) async { @@ -111,6 +111,11 @@ void main() { await tester.pumpWidget( MaterialApp( theme: ThemeData( + pageTransitionsTheme: const PageTransitionsTheme( + builders: { + TargetPlatform.android: FadeForwardsPageTransitionsBuilder() + } + ), colorScheme: ThemeData().colorScheme.copyWith(surface: Colors.pink) ), routes: routes, @@ -199,6 +204,13 @@ void main() { await tester.pumpWidget( MaterialApp( + theme: ThemeData( + pageTransitionsTheme: const PageTransitionsTheme( + builders: { + TargetPlatform.android: FadeForwardsPageTransitionsBuilder() + } + ), + ), routes: routes, ), ); @@ -296,7 +308,6 @@ void main() { expect(find.byType(ColoredBox), findsNothing); }, variant: TargetPlatformVariant.only(TargetPlatform.android)); - testWidgets('PageTransitionsTheme override builds a _OpenUpwardsPageTransition', (WidgetTester tester) async { final Map routes = { '/': (BuildContext context) => Material(