DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disable flaky/hanging split AOT test (flutter/engine#23070)

Browse Source
This commit is contained in:
Gary Qian 2020-12-15 22:18:07 -07:00 committed by GitHub
parent c17922e187
commit d7ab4b01cd
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
engine/src/flutter/runtime/dart_isolate_unittests.cc
View File

@ -487,7 +487,9 @@ TEST_F(DartIsolateTest, InvalidLoadingUnitFails) {
ASSERT_TRUE(root_isolate->Shutdown());
}
TEST_F(DartIsolateTest, ValidLoadingUnitSucceeds) {
// TODO(garyq): Re-enable this test, and resolve dart-side hanging future and
// threading. See https://github.com/flutter/flutter/issues/72312
TEST_F(DartIsolateTest, DISABLED_ValidLoadingUnitSucceeds) {
if (!DartVM::IsRunningPrecompiledCode()) {
FML_LOG(INFO) << "Split AOT does not work in JIT mode";
return;
@ -529,6 +531,7 @@ TEST_F(DartIsolateTest, ValidLoadingUnitSucceeds) {
ASSERT_TRUE(isolate->get()->LoadLoadingUnit(2, std::move(isolate_data),
std::move(isolate_instructions)));
Wait();
}
} // namespace testing