From d7774b2f1b9c4eca2586567b06f217dc5cf6fcd6 Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Mon, 24 May 2021 15:57:45 -0500 Subject: [PATCH] Fix race with engine destruction in `Shell` (flutter/engine#26369) --- engine/src/flutter/shell/common/shell.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/engine/src/flutter/shell/common/shell.cc b/engine/src/flutter/shell/common/shell.cc index 88269ff0a4f..b6c9f859553 100644 --- a/engine/src/flutter/shell/common/shell.cc +++ b/engine/src/flutter/shell/common/shell.cc @@ -427,8 +427,8 @@ Shell::~Shell() { fml::TaskRunner::RunNowOrPostTask( task_runners_.GetUITaskRunner(), - fml::MakeCopyable([engine = std::move(engine_), &ui_latch]() mutable { - engine.reset(); + fml::MakeCopyable([this, &ui_latch]() mutable { + engine_.reset(); ui_latch.Signal(); })); ui_latch.Wait();