DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Icon should use an enum rather than an int for size

Browse Source 
Material design icons are defined to work at specific sizes: 18, 24, 36, 48.
The current API doesn't reflect that and just takes a size int. If an invalid
size is chosen an error is printed to the console and no icon shows up.

Fixes #1816
This commit is contained in:
Adam Barth 2015-10-28 07:26:09 -07:00
parent dfe47456b9
commit d749a73805
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/examples/address_book/lib/main.dart
View File

@ -20,7 +20,7 @@ class Field extends StatelessComponent {
return new Row(<Widget>[
new Padding(
padding: const EdgeDims.symmetric(horizontal: 16.0),
child: new Icon(type: icon, size: 24)
child: new Icon(type: icon)
),
new Flexible(
child: new Input(
@ -43,7 +43,7 @@ class AddressBookHome extends StatelessComponent {
Widget buildFloatingActionButton(BuildContext context) {
return new FloatingActionButton(
child: new Icon(type: 'image/photo_camera', size: 24),
child: new Icon(type: 'image/photo_camera'),
backgroundColor: Theme.of(context).accentColor
);
}