DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Temporarily disable Dart Development Service in flutter_tools (#62508)

Browse Source 
Devtools doesn't currently support connections to DDS. Disable DDS
temporarily while a solution is worked on. See https://github.com/flutter/flutter/issues/62507
This commit is contained in:
Ben Konyi 2020-07-29 12:32:10 -07:00 committed by GitHub
parent 22bf19cece
commit d6a25ae699
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter_tools/lib/src/base/dds.dart
View File

@ -15,6 +15,9 @@ import 'logger.dart';
class DartDevelopmentService {
DartDevelopmentService({@required this.logger});
// TODO(bkonyi): enable once VM service can handle SSE forwarding for
// Devtools (https://github.com/flutter/flutter/issues/62507)
static const bool ddsDisabled = true;
final Logger logger;
dds.DartDevelopmentService _ddsInstance;
@ -22,6 +25,13 @@ class DartDevelopmentService {
Uri observatoryUri,
bool ipv6,
) async {
if (ddsDisabled) {
logger.printTrace(
'DDS is currently disabled due to '
'https://github.com/flutter/flutter/issues/62507'
);
return;
}
final Uri ddsUri = Uri(
scheme: 'http',
host: (ipv6 ?

3
packages/flutter_tools/test/integration.shard/vmservice_integration_test.dart
View File

@ -6,6 +6,7 @@ import 'dart:async';
import 'dart:io'; // ignore: dart_io_import
import 'package:file/file.dart';
import 'package:flutter_tools/src/base/dds.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:matcher/matcher.dart';
import 'package:vm_service/vm_service.dart';
@ -46,7 +47,7 @@ void main() {
for (final Protocol protocol in protocolList.protocols) {
expect(protocol.protocolName, anyOf('VM Service', 'DDS'));
}
});
}, skip: DartDevelopmentService.ddsDisabled);
test('flutterVersion can be called', () async {
final Response response =