From d50e006297983676324cac449ec6bbad767ef424 Mon Sep 17 00:00:00 2001 From: Nhan Nguyen Date: Tue, 3 Feb 2026 14:37:25 -0500 Subject: [PATCH] Remove unnecessary Material import from cupertino/slider_test.dart (#180957) ## Description Remove unnecessary Material import and Material widget wrappers from `cupertino/slider_test.dart`. The CupertinoSlider tests were using `Material` widget wrappers unnecessarily. CupertinoSlider is a Cupertino widget that doesn't require Material ancestors. ## Related Issue Contributes to #177412 ## Tests All 21 tests in `slider_test.dart` pass after this change. --- dev/bots/check_tests_cross_imports.dart | 1 - .../flutter/test/cupertino/slider_test.dart | 225 ++++++++---------- 2 files changed, 103 insertions(+), 123 deletions(-) diff --git a/dev/bots/check_tests_cross_imports.dart b/dev/bots/check_tests_cross_imports.dart index 3629019edc7..5aff5944b7b 100644 --- a/dev/bots/check_tests_cross_imports.dart +++ b/dev/bots/check_tests_cross_imports.dart @@ -267,7 +267,6 @@ class TestsCrossImportChecker { 'packages/flutter/test/cupertino/form_row_test.dart', 'packages/flutter/test/cupertino/colors_test.dart', 'packages/flutter/test/cupertino/text_form_field_row_restoration_test.dart', - 'packages/flutter/test/cupertino/slider_test.dart', }; static final Set _knownCrossImports = knownWidgetsCrossImports.union( diff --git a/packages/flutter/test/cupertino/slider_test.dart b/packages/flutter/test/cupertino/slider_test.dart index 48c3e55c720..3e26cb8487f 100644 --- a/packages/flutter/test/cupertino/slider_test.dart +++ b/packages/flutter/test/cupertino/slider_test.dart @@ -5,7 +5,6 @@ import 'package:flutter/cupertino.dart'; import 'package:flutter/foundation.dart'; import 'package:flutter/gestures.dart'; -import 'package:flutter/material.dart'; import 'package:flutter/rendering.dart'; import 'package:flutter/scheduler.dart'; import 'package:flutter/services.dart'; @@ -42,17 +41,15 @@ void main() { textDirection: TextDirection.ltr, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, ), ); }, @@ -80,17 +77,15 @@ void main() { textDirection: TextDirection.rtl, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, ), ); }, @@ -121,20 +116,18 @@ void main() { textDirection: TextDirection.ltr, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - onChangeStart: (double value) { - numberOfTimesOnChangeStartIsCalled++; - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, + onChangeStart: (double value) { + numberOfTimesOnChangeStartIsCalled++; + }, ), ); }, @@ -166,20 +159,18 @@ void main() { textDirection: TextDirection.ltr, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - onChangeEnd: (double value) { - numberOfTimesOnChangeEndIsCalled++; - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, + onChangeEnd: (double value) { + numberOfTimesOnChangeEndIsCalled++; + }, ), ); }, @@ -210,23 +201,21 @@ void main() { textDirection: TextDirection.ltr, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - onChangeStart: (double value) { - startValue = value; - }, - onChangeEnd: (double value) { - endValue = value; - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, + onChangeStart: (double value) { + startValue = value; + }, + onChangeEnd: (double value) { + endValue = value; + }, ), ); }, @@ -273,17 +262,15 @@ void main() { textDirection: TextDirection.ltr, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, ), ); }, @@ -359,17 +346,15 @@ void main() { textDirection: TextDirection.ltr, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, ), ); }, @@ -402,27 +387,25 @@ void main() { textDirection: TextDirection.rtl, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - onChangeStart: (double value) { - setState(() { - startValue = value; - }); - }, - onChangeEnd: (double value) { - setState(() { - endValue = value; - }); - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, + onChangeStart: (double value) { + setState(() { + startValue = value; + }); + }, + onChangeEnd: (double value) { + setState(() { + endValue = value; + }); + }, ), ); }, @@ -792,17 +775,15 @@ void main() { textDirection: TextDirection.ltr, child: StatefulBuilder( builder: (BuildContext context, StateSetter setState) { - return Material( - child: Center( - child: CupertinoSlider( - key: sliderKey, - value: value, - onChanged: (double newValue) { - setState(() { - value = newValue; - }); - }, - ), + return Center( + child: CupertinoSlider( + key: sliderKey, + value: value, + onChanged: (double newValue) { + setState(() { + value = newValue; + }); + }, ), ); },