From d05d99805fa3855c2b7e727f35c468aeeea5fe1e Mon Sep 17 00:00:00 2001 From: Jim Graham Date: Tue, 25 Apr 2023 12:46:26 -0700 Subject: [PATCH] hide DisplayList::DisposeOps and other lint suggestions (flutter/engine#41464) Fixes https://github.com/flutter/flutter/issues/125428 Note that these are lint-type fixes and so there are no tests for them. --- engine/src/flutter/display_list/display_list.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/engine/src/flutter/display_list/display_list.h b/engine/src/flutter/display_list/display_list.h index cbc9eb7925d..6820434418b 100644 --- a/engine/src/flutter/display_list/display_list.h +++ b/engine/src/flutter/display_list/display_list.h @@ -257,15 +257,13 @@ class DisplayList : public SkRefCnt { bool Equals(const DisplayList* other) const; bool Equals(const DisplayList& other) const { return Equals(&other); } - bool Equals(sk_sp other) const { + bool Equals(const sk_sp& other) const { return Equals(other.get()); } bool can_apply_group_opacity() const { return can_apply_group_opacity_; } bool isUIThreadSafe() const { return is_ui_thread_safe_; } - static void DisposeOps(uint8_t* ptr, uint8_t* end); - private: DisplayList(DisplayListStorage&& ptr, size_t byte_count, @@ -279,6 +277,8 @@ class DisplayList : public SkRefCnt { static uint32_t next_unique_id(); + static void DisposeOps(uint8_t* ptr, uint8_t* end); + const DisplayListStorage storage_; const size_t byte_count_; const unsigned int op_count_;