From cddc8f5910b4b6320fb5527f4cf83f23bc1da48c Mon Sep 17 00:00:00 2001 From: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Date: Fri, 29 Mar 2024 11:50:35 -0700 Subject: [PATCH] Turn struct half leading in canvaskit kitchensink test back on (flutter/engine#50707) Undo https://github.com/flutter/engine/pull/50617 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style --- .../lib/web_ui/test/canvaskit/canvaskit_api_test.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/engine/src/flutter/lib/web_ui/test/canvaskit/canvaskit_api_test.dart b/engine/src/flutter/lib/web_ui/test/canvaskit/canvaskit_api_test.dart index 69d9f6bf859..bc7eec8660b 100644 --- a/engine/src/flutter/lib/web_ui/test/canvaskit/canvaskit_api_test.dart +++ b/engine/src/flutter/lib/web_ui/test/canvaskit/canvaskit_api_test.dart @@ -1596,7 +1596,7 @@ void _paragraphTests() { ..weight = canvasKit.FontWeight.Bold) ..fontSize = 72 ..heightMultiplier = 1.5 - ..halfLeading = false + ..halfLeading = true ..leading = 0 ..strutEnabled = true ..forceStrutHeight = false; @@ -1673,7 +1673,7 @@ void _paragraphTests() { expect(actual, within(distance: actual / 100, from: expected)); } - expectAlmost(paragraph.getAlphabeticBaseline(), 85.5); + expectAlmost(paragraph.getAlphabeticBaseline(), 78.6); expect(paragraph.didExceedMaxLines(), isFalse); expectAlmost(paragraph.getHeight(), 108); expectAlmost(paragraph.getIdeographicBaseline(), 108); @@ -1699,7 +1699,7 @@ void _paragraphTests() { expectAlmost(lineMetrics.ascent, 55.6); expectAlmost(lineMetrics.descent, 14.8); expect(lineMetrics.isHardBreak, isTrue); - expectAlmost(lineMetrics.baseline, 85.5); + expectAlmost(lineMetrics.baseline, 78.6); expectAlmost(lineMetrics.height, 108); expectAlmost(lineMetrics.left, 2.5); expectAlmost(lineMetrics.width, 263);