DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't populate the external view embedder in PaintContext. (#6686)

Browse Source 
The platform views embedding is still WIP, and until we dynamically
merge the gpu and platform threads based on the presence of an embedded
view in the scene fetching the view embedder is not thread safe.

This PR essentially disables iOS platform views embedding, we will
re-enable once dynamic thread merging is supported.
This commit is contained in:
Amir Hardon 2018-10-29 10:38:04 -07:00 committed by GitHub
parent ab782faa77
commit cc686d7aeb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
shell/common/rasterizer.cc
View File

@ -162,8 +162,19 @@ bool Rasterizer::DrawToSurface(flow::LayerTree& layer_tree) {
auto canvas = frame->SkiaCanvas();
// External view embedding required that the gpu and platform threads are the
// same. The dynamic merging of these threads is WIP so for now we don't
// populate the view embedder. Once we can merge the threads, we should
// populate the view embedded here with surface_->GetExternalViewEmbedder() if
// the scene contains an external view (and we can probably assert that the
// gpu and platform threads are the same).
//
// TODO(amirh): populate the view embedder once we dynamically merge the
// threads for embedded platform views.
auto external_view_embedder = nullptr;
auto compositor_frame = compositor_context_->AcquireFrame(
surface_->GetContext(), canvas, surface_->GetExternalViewEmbedder(),
surface_->GetContext(), canvas, external_view_embedder,
surface_->GetRootTransformation(), true);
if (canvas) {