From cc2776129d3c6fac716c1eccc7595fca4e9109cd Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Tue, 3 Jul 2018 17:17:57 -0700 Subject: [PATCH] Do not make an extra submit callback during SurfaceFrame destruction if the frame was already submitted (flutter/engine#5669) --- engine/src/flutter/shell/common/surface.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/src/flutter/shell/common/surface.cc b/engine/src/flutter/shell/common/surface.cc index d9b620fbc63..7101f6e5c40 100644 --- a/engine/src/flutter/shell/common/surface.cc +++ b/engine/src/flutter/shell/common/surface.cc @@ -21,7 +21,7 @@ SurfaceFrame::SurfaceFrame(sk_sp surface, } SurfaceFrame::~SurfaceFrame() { - if (submit_callback_) { + if (submit_callback_ && !submitted_) { // Dropping without a Submit. submit_callback_(*this, nullptr); }