From cbc8ee416c3cb446ff73ea2d6cc9ad8973516ba3 Mon Sep 17 00:00:00 2001 From: Jonah Williams Date: Wed, 9 Apr 2025 15:42:50 -0700 Subject: [PATCH] [Impeller] prefer 24 bit depth buffer format on vulkan backend. (#166854) We really only need 24 bits of depth. 32 can be used as a fallback instead of the other way around. --- .../impeller/renderer/backend/vulkan/capabilities_vk.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/capabilities_vk.cc b/engine/src/flutter/impeller/renderer/backend/vulkan/capabilities_vk.cc index 7cd75c70631..839b1e68cc5 100644 --- a/engine/src/flutter/impeller/renderer/backend/vulkan/capabilities_vk.cc +++ b/engine/src/flutter/impeller/renderer/backend/vulkan/capabilities_vk.cc @@ -520,11 +520,11 @@ bool CapabilitiesVK::SetPhysicalDevice( default_color_format_ = PixelFormat::kUnknown; } - if (HasSuitableDepthStencilFormat(device, vk::Format::eD32SfloatS8Uint)) { - default_depth_stencil_format_ = PixelFormat::kD32FloatS8UInt; - } else if (HasSuitableDepthStencilFormat(device, - vk::Format::eD24UnormS8Uint)) { + if (HasSuitableDepthStencilFormat(device, vk::Format::eD24UnormS8Uint)) { default_depth_stencil_format_ = PixelFormat::kD24UnormS8Uint; + } else if (HasSuitableDepthStencilFormat(device, + vk::Format::eD32SfloatS8Uint)) { + default_depth_stencil_format_ = PixelFormat::kD32FloatS8UInt; } else { default_depth_stencil_format_ = PixelFormat::kUnknown; }