DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove uses of ReleaseOwnership from vulkan backend (flutter/engine#5458)

Browse Source 
* Remove uses of ReleaseOwnership from vulkan backend.

Flutter no longer needs to release ownership of objects to skia so this change removes the api calls.

* Remove Release call from vulkan_device.cc

* Update vulkan_application.h

* Update vulkan_application.cc

* Update vulkan_handle.h
This commit is contained in:
egdaniel 2018-06-04 15:46:24 -04:00 committed by Brian Osman
parent 5672a9b6a1
commit c853d53156
5 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/vulkan/vulkan_application.cc
View File

@ -129,10 +129,6 @@ const VulkanHandle<VkInstance>& VulkanApplication::GetInstance() const {
return instance_;
}
void VulkanApplication::ReleaseInstanceOwnership() {
instance_.ReleaseOwnership();
}
std::vector<VkPhysicalDevice> VulkanApplication::GetPhysicalDevices() const {
if (!IsValid()) {
return {};

2
engine/src/flutter/vulkan/vulkan_application.h
View File

@ -38,8 +38,6 @@ class VulkanApplication {
const VulkanHandle<VkInstance>& GetInstance() const;
void ReleaseInstanceOwnership();
std::unique_ptr<VulkanDevice> AcquireFirstCompatibleLogicalDevice() const;
private:

4
engine/src/flutter/vulkan/vulkan_device.cc
View File

@ -153,10 +153,6 @@ const VulkanHandle<VkDevice>& VulkanDevice::GetHandle() const {
return device_;
}
void VulkanDevice::ReleaseDeviceOwnership() {
device_.ReleaseOwnership();
}
const VulkanHandle<VkPhysicalDevice>& VulkanDevice::GetPhysicalDeviceHandle()
const {
return physical_device_;

2
engine/src/flutter/vulkan/vulkan_device.h
View File

@ -35,8 +35,6 @@ class VulkanDevice {
uint32_t GetGraphicsQueueIndex() const;
void ReleaseDeviceOwnership();
FXL_WARN_UNUSED_RESULT
bool GetSurfaceCapabilities(const VulkanSurface& surface,
VkSurfaceCapabilitiesKHR* capabilities) const;

5
engine/src/flutter/vulkan/vulkan_handle.h
View File

@ -50,11 +50,6 @@ class VulkanHandle {
operator Handle() const { return handle_; }
/// Relinquish responsibility of collecting the underlying handle when this
/// object is collected. It is the responsibility of the caller to ensure that
/// the lifetime of the handle extends past the lifetime of this object.
void ReleaseOwnership() { disposer_ = nullptr; }
void Reset() { DisposeIfNecessary(); }
private: