From c755577d73ba16f4855b2c013abc68f211885a7f Mon Sep 17 00:00:00 2001 From: Eric Seidel Date: Fri, 5 Dec 2014 15:46:07 -0800 Subject: [PATCH] Fix the sky build instructions Sky can't really build on its own. We were previously using the 'sky' build target for this but it didn't fully anticipate all of our dependencies. The most recent break was when James removed /mojo/shell from mojo. Instead of sky listing out each and every service which it depends on, we should just get used to building root like other mojo developers. Thankfully there is already a helpful tool for this called mojob.py. I've updated our readme to reflect this, and removed the mojo dependency on the sky build group. The purpose of the sky build group is to expose all of the sky build targets up to the root level BUILD.gn (which only depends on /sky), not to be an independently buildable target. R=jamesr@chromium.org, jamesr BUG= Review URL: https://codereview.chromium.org/764023007 --- BUILD.gn | 1 - HACKING.md | 6 ------ 2 files changed, 7 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 5a686fbbd74..f40a6ca52e4 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -9,7 +9,6 @@ group("sky") { testonly = true deps = [ - "//mojo", "//sky/engine/platform:platform_unittests", "//sky/engine/web:sky_unittests", "//sky/engine/wtf:unittests", diff --git a/HACKING.md b/HACKING.md index c0c56880519..b2c18c2dbf5 100644 --- a/HACKING.md +++ b/HACKING.md @@ -5,12 +5,6 @@ Building -------- * Follow the setup & build instructions for [Mojo](https://github.com/domokit/mojo) -* Build ``sky`` with ``ninja``, e.g. ``ninja -C out/Debug sky`` for a debug build. - -If you want to build release, run the following commands: - -* ``gn gen out/Release --args="is_debug=false"`` -* ``ninja -C out/Release sky`` Running applications --------------------