From c6dea5e4b4fcee7d1913fa1dc03bbc3fa8146397 Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Tue, 5 Nov 2024 15:49:01 -0800 Subject: [PATCH] Remove unused `enableObservatory` flag. (#158202) I checked google3 as well and couldn't find any reference. --- packages/flutter_tools/lib/src/test/flutter_platform.dart | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/flutter_tools/lib/src/test/flutter_platform.dart b/packages/flutter_tools/lib/src/test/flutter_platform.dart index 18bf8fe98f5..1e3e2b4a034 100644 --- a/packages/flutter_tools/lib/src/test/flutter_platform.dart +++ b/packages/flutter_tools/lib/src/test/flutter_platform.dart @@ -54,8 +54,6 @@ FlutterPlatform installHook({ required String shellPath, required DebuggingOptions debuggingOptions, TestWatcher? watcher, - // TODO(bkonyi): remove after roll into google3. - bool enableObservatory = false, bool enableVmService = false, bool machine = false, String? precompiledDillPath, @@ -73,7 +71,7 @@ FlutterPlatform installHook({ TestCompilerNativeAssetsBuilder? nativeAssetsBuilder, BuildInfo? buildInfo, }) { - assert(enableVmService || enableObservatory || (!debuggingOptions.startPaused && debuggingOptions.hostVmServicePort == null)); + assert(enableVmService || (!debuggingOptions.startPaused && debuggingOptions.hostVmServicePort == null)); // registerPlatformPlugin can be injected for testing since it's not very mock-friendly. platformPluginRegistration ??= (FlutterPlatform platform) { @@ -89,7 +87,7 @@ FlutterPlatform installHook({ debuggingOptions: debuggingOptions, watcher: watcher, machine: machine, - enableVmService: enableVmService || enableObservatory, + enableVmService: enableVmService, host: _kHosts[serverType], precompiledDillPath: precompiledDillPath, precompiledDillFiles: precompiledDillFiles,