Fix missing return statements on function literals (#33058)

This commit is contained in:
Sam Rawlins 2019-05-20 12:51:57 -07:00 committed by Michael Goderbauer
parent 539ff20384
commit c2a93bd545
7 changed files with 8 additions and 4 deletions

View File

@ -243,6 +243,7 @@ class _LeaveBehindListItem extends StatelessWidget {
case DismissDirection.down:
assert(false);
}
return true;
},
background: Container(
color: theme.primaryColor,

View File

@ -2250,4 +2250,5 @@ final HeroFlightShuttleBuilder _navBarHeroFlightShuttleBuilder = (
topNavBar: fromNavBar,
);
}
return null;
};

View File

@ -101,7 +101,7 @@ Future<T> _warnIfSlow<T>({
assert(future != null);
assert(timeout != null);
assert(message != null);
return future..timeout(timeout, onTimeout: () { _log.warning(message); });
return future..timeout(timeout, onTimeout: () { _log.warning(message); return null; });
}
/// A convenient accessor to frequently used finders.

View File

@ -764,6 +764,7 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
final Uint8List encoded = Uint8List.fromList(asset.readAsBytesSync());
return Future<ByteData>.value(encoded.buffer.asByteData());
}
return null;
});
}
}

View File

@ -164,7 +164,7 @@ void main() {
);
});
testWidgets('TestWindow can clear out fake properties all at once', (WidgetTester tester) {
testWidgets('TestWindow can clear out fake properties all at once', (WidgetTester tester) async {
final double originalDevicePixelRatio = ui.window.devicePixelRatio;
final double originalTextScaleFactor = ui.window.textScaleFactor;
final TestWindow testWindow = retrieveTestBinding(tester).window;

View File

@ -79,8 +79,9 @@ class Testbed {
}
await test();
Cache.flutterRoot = originalFlutterRoot;
return null;
}
);
});
}
}
}

View File

@ -19,7 +19,7 @@ void main() {
setUp(() {
testbed = Testbed(
setup: () {
setup: () async {
fs.file('pubspec.yaml').createSync();
fs.file('.packages').createSync();
fs.file('test/foo.dart').createSync(recursive: true);