DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove SK_USE_LEGACY_BLUR_RASTER staging flag (flutter/engine#56618)

Browse Source 
Also updates the image_filter_test.dart expected color values for a blur unit test. The legacy blur algorithm would a) treat very small blur sigmas as the identity even though the effect was still perceptible and b) was very inaccurate for sigmas < 2.  The unit test used a sigma of 1.0 so fell within the inaccurate range but the expected values appear to have been taken directly from the original Skia output.  This updates them to match the output of the new algorithm (which is also more consistent between CPU and GPU).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This commit is contained in:
Michael Ludwig 2024-11-18 21:28:26 -05:00 committed by GitHub
parent 98a631d40a
commit c0e6c19e09
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
engine/src/flutter/skia/flutter_defines.gni
View File

@ -13,7 +13,6 @@ flutter_defines = [
"SK_LEGACY_IGNORE_DRAW_VERTICES_BLEND_WITH_NO_SHADER",
"SK_DISABLE_LEGACY_METAL_BACKEND_SURFACE",
"SK_DISABLE_LEGACY_PARAGRAPH_UNICODE",
"SK_USE_LEGACY_BLUR_RASTER",
# Fast low-precision software rendering isn't a priority for Flutter.
"SK_DISABLE_LEGACY_SHADERCONTEXT",

6
engine/src/flutter/testing/dart/image_filter_test.dart
View File

@ -14,9 +14,9 @@ import 'impeller_enabled.dart';
const Color red = Color(0xFFAA0000);
const Color green = Color(0xFF00AA00);
const int greenCenterBlurred = 0x1C001300;
const int greenSideBlurred = 0x15000E00;
const int greenCornerBlurred = 0x10000A00;
const int greenCenterBlurred = 0x29001B00;
const int greenSideBlurred = 0x19001000;
const int greenCornerBlurred = 0x0F000A00;
const int greenCenterScaled = 0xFF00AA00;
const int greenSideScaled = 0x80005500;