DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix Memory Leak in MakeSkSurfaceFromBackingStore (flutter/engine#30735)

Browse Source
This commit is contained in:
Lyle Dean 2022-01-24 15:55:11 +00:00 committed by GitHub
parent 40365e0cbb
commit bcbd90ac89
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engine/src/flutter/shell/platform/embedder/embedder.cc
View File

@ -558,6 +558,7 @@ static sk_sp<SkSurface> MakeSkSurfaceFromBackingStore(
if (captures->destruction_callback) {
captures->destruction_callback(captures->user_data);
}
delete captures;
};
auto surface = SkSurface::MakeRasterDirectReleaseProc(
@ -565,7 +566,7 @@ static sk_sp<SkSurface> MakeSkSurfaceFromBackingStore(
const_cast<void*>(software->allocation), // pixels
software->row_bytes, // row bytes
release_proc, // release proc
captures.release() // release context
captures.get() // get context
);
if (!surface) {
@ -576,6 +577,9 @@ static sk_sp<SkSurface> MakeSkSurfaceFromBackingStore(
}
return nullptr;
}
if (surface) {
captures.release(); // Skia has assumed ownership of the struct.
}
return surface;
}