From b8fd0013a8ff2cd5a75af4aecab6e8e39af592d2 Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Fri, 16 Oct 2020 16:08:36 -0700 Subject: [PATCH] Update FLUTTER_NOLINT uses to include issue link (#21921) In an upcoming patch, we'll enable enforcement that all FLUTTER_NOLINT comments include an issue link. This migrates the remaining uses to that format. Bug: https://github.com/flutter/flutter/issues/68273 --- shell/platform/linux/fl_json_message_codec.cc | 4 ---- shell/version/version.cc | 3 ++- vulkan/vulkan_window.cc | 3 ++- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/shell/platform/linux/fl_json_message_codec.cc b/shell/platform/linux/fl_json_message_codec.cc index 3fbfb1238ea..7441ebe63c6 100644 --- a/shell/platform/linux/fl_json_message_codec.cc +++ b/shell/platform/linux/fl_json_message_codec.cc @@ -2,10 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// TODO(cbracken): lint disabled due to rapidjson null deref issue. -// https://github.com/flutter/flutter/issues/65676 -// FLUTTER_NOLINT - #include "flutter/shell/platform/linux/public/flutter_linux/fl_json_message_codec.h" #include diff --git a/shell/version/version.cc b/shell/version/version.cc index 54ff4cb07ba..77baa13107c 100644 --- a/shell/version/version.cc +++ b/shell/version/version.cc @@ -1,7 +1,8 @@ // Copyright 2013 The Flutter Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// FLUTTER_NOLINT + +// FLUTTER_NOLINT: https://github.com/flutter/flutter/issues/68332 #include "flutter/shell/version/version.h" diff --git a/vulkan/vulkan_window.cc b/vulkan/vulkan_window.cc index 2e1b9956743..2c4618f06e7 100644 --- a/vulkan/vulkan_window.cc +++ b/vulkan/vulkan_window.cc @@ -1,7 +1,8 @@ // Copyright 2013 The Flutter Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// FLUTTER_NOLINT + +// FLUTTER_NOLINT: https://github.com/flutter/flutter/issues/68331 #include "vulkan_window.h"