mirror of
https://github.com/flutter/flutter.git
synced 2026-02-20 02:29:02 +08:00
Remove passing of --debugger-module-names flag to frontend server (#109791)
The flag is true by default so the behavior does not change.
Next steps:
Use the flag for updated debugger module names:
- Frontend server: make the current behavior controlled
by the flag non-conditional
- Frontend server: add more debugging names changes under
the same flag, false by default
- Dwds: make changes required for the new module names.
- Flutter tools: when matching dwds changes roll to flutter,
pass the flag to the frontend server again.
- Cleanup:
- Frontend server: make new behavior default
- Flutter tools: remove uses of the flag.
- Frontend server: remove the flag.
Towards: https://github.com/dart-lang/webdev/issues/1692
Helps: https://github.com/flutter/flutter/issues/106727
This commit is contained in:
parent
3b6e3a6938
commit
b7c500fc6b
@ -753,10 +753,6 @@ class DefaultResidentCompiler implements ResidentCompiler {
|
||||
if (testCompilation)
|
||||
'--no-print-incremental-dependencies',
|
||||
'--target=$targetModel',
|
||||
// TODO(zanderso): remove once this becomes the default behavior
|
||||
// in the frontend_server.
|
||||
// https://github.com/flutter/flutter/issues/52693
|
||||
'--debugger-module-names',
|
||||
// TODO(annagrin): remove once this becomes the default behavior
|
||||
// in the frontend_server.
|
||||
// https://github.com/flutter/flutter/issues/59902
|
||||
|
||||
@ -521,7 +521,7 @@ class ResidentWebRunner extends ResidentRunner {
|
||||
final Chromium chrome = await _chromiumLauncher!.connectedInstance;
|
||||
final ChromeTab chromeTab = await (chrome.chromeConnection.getTab((ChromeTab chromeTab) {
|
||||
return !chromeTab.url.startsWith('chrome-extension');
|
||||
}) as FutureOr<ChromeTab>);
|
||||
}, retryFor: const Duration(seconds: 5)) as FutureOr<ChromeTab>);
|
||||
if (chromeTab == null) {
|
||||
throwToolExit('Failed to connect to Chrome instance.');
|
||||
}
|
||||
|
||||
@ -36,7 +36,6 @@ void main() {
|
||||
'sdkroot/',
|
||||
'--incremental',
|
||||
'--target=flutter',
|
||||
'--debugger-module-names',
|
||||
'--experimental-emit-debug-metadata',
|
||||
'--output-dill',
|
||||
'/build/',
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user