DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

Browse Source
This commit is contained in:
Brandon DeRosier 2022-12-16 10:35:10 -08:00 committed by GitHub
parent 5f1aeb0603
commit b74e879a3f
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engine/src/flutter/impeller/fixtures/BUILD.gn
View File

@ -34,7 +34,10 @@ impeller_shaders("shader_fixtures") {
}
scenec("scene_fixtures") {
geometry = [ "flutter_logo.glb" ]
geometry = [
"flutter_logo.glb",
"two_triangles.glb",
]
type = "gltf"
}
@ -79,6 +82,7 @@ test_fixtures("file_fixtures") {
"table_mountain_py.png",
"table_mountain_pz.png",
"test_texture.frag",
"two_triangles.glb",
"types.h",
"wtf.otf",
]

BIN
engine/src/flutter/impeller/fixtures/two_triangles.glb Normal file
View File

Binary file not shown.

2
engine/src/flutter/impeller/scene/importer/importer_gltf.cc
View File

@ -189,7 +189,7 @@ static void ProcessNode(const tinygltf::Model& gltf,
/// Children.
///
for (size_t node_i = 0; node_i < out_node.children.size(); node_i++) {
for (size_t node_i = 0; node_i < in_node.children.size(); node_i++) {
auto child = std::make_unique<fb::NodeT>();
ProcessNode(gltf, gltf.nodes[in_node.children[node_i]], *child);
out_node.children.push_back(std::move(child));