From b7336cd8629909e4f0a52485bdcd0c1bc66d9fbf Mon Sep 17 00:00:00 2001 From: Elliott Sprehn Date: Fri, 9 Jan 2015 18:18:47 -0800 Subject: [PATCH] Remove shadowPseudoElementRules. Nothing uses this now, it was for custom pseudo elements that don't exist in Sky. R=ojan@chromium.org Review URL: https://codereview.chromium.org/786953008 --- engine/core/css/RuleSet.cpp | 9 --------- engine/core/css/RuleSet.h | 3 --- 2 files changed, 12 deletions(-) diff --git a/engine/core/css/RuleSet.cpp b/engine/core/css/RuleSet.cpp index a5e114f2951..d62931dbc83 100644 --- a/engine/core/css/RuleSet.cpp +++ b/engine/core/css/RuleSet.cpp @@ -109,14 +109,6 @@ bool RuleSet::findBestRuleSetAndAdd(const CSSSelector& component, RuleData& rule addToRuleSet(className, ensurePendingRules()->classRules, ruleData); return true; } - if (!customPseudoElementName.isEmpty()) { - // Custom pseudos come before ids and classes in the order of tagHistory, and have a relation of - // ShadowPseudo between them. Therefore we should never be a situation where extractValuesforSelector - // finsd id and className in addition to custom pseudo. - ASSERT(id.isEmpty() && className.isEmpty()); - addToRuleSet(customPseudoElementName, ensurePendingRules()->shadowPseudoElementRules, ruleData); - return true; - } if (!tagName.isEmpty()) { addToRuleSet(tagName, ensurePendingRules()->tagRules, ruleData); @@ -208,7 +200,6 @@ void RuleSet::compactRules() compactPendingRules(pendingRules->idRules, m_idRules); compactPendingRules(pendingRules->classRules, m_classRules); compactPendingRules(pendingRules->tagRules, m_tagRules); - compactPendingRules(pendingRules->shadowPseudoElementRules, m_shadowPseudoElementRules); m_universalRules.shrinkToFit(); m_fontFaceRules.shrinkToFit(); m_keyframesRules.shrinkToFit(); diff --git a/engine/core/css/RuleSet.h b/engine/core/css/RuleSet.h index 95722592d14..933c91c53f5 100644 --- a/engine/core/css/RuleSet.h +++ b/engine/core/css/RuleSet.h @@ -81,7 +81,6 @@ public: const TerminatedArray* idRules(const AtomicString& key) const { ASSERT(!m_pendingRules); return m_idRules.get(key); } const TerminatedArray* classRules(const AtomicString& key) const { ASSERT(!m_pendingRules); return m_classRules.get(key); } const TerminatedArray* tagRules(const AtomicString& key) const { ASSERT(!m_pendingRules); return m_tagRules.get(key); } - const TerminatedArray* shadowPseudoElementRules(const AtomicString& key) const { ASSERT(!m_pendingRules); return m_shadowPseudoElementRules.get(key); } const Vector* universalRules() const { ASSERT(!m_pendingRules); return &m_universalRules; } const Vector >& fontFaceRules() const { return m_fontFaceRules; } const Vector >& keyframesRules() const { return m_keyframesRules; } @@ -124,7 +123,6 @@ private: PendingRuleMap idRules; PendingRuleMap classRules; PendingRuleMap tagRules; - PendingRuleMap shadowPseudoElementRules; private: PendingRuleMaps() { } @@ -140,7 +138,6 @@ private: CompactRuleMap m_idRules; CompactRuleMap m_classRules; CompactRuleMap m_tagRules; - CompactRuleMap m_shadowPseudoElementRules; Vector m_universalRules; RuleFeatureSet m_features; Vector > m_fontFaceRules;