DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

[flutter_tools] test and catch more exception types in web runner (#53183)

Browse Source
This commit is contained in:
Jonah Williams 2020-03-24 12:58:30 -07:00 committed by GitHub
parent d6614dbafd
commit b5cd3ce854
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 52 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart
View File

@ -520,6 +520,8 @@ class _ResidentWebRunner extends ResidentWebRunner {
return OperationResult(1, err.toString(), fatal: true);
} on WipError catch (err) {
return OperationResult(1, err.toString(), fatal: true);
} on vmservice.RPCError catch (err) {
return OperationResult(1, err.toString(), fatal: true);
} finally {
status.stop();
}

93
packages/flutter_tools/test/general.shard/resident_web_runner_test.dart
View File

@ -513,54 +513,61 @@ void main() {
Usage: () => MockFlutterUsage(),
}));
// TODO(jonahwilliams): re-enable tests once we switch back to DWDS for hot reload/restart.
// test('Fails on vmservice response error for hot restart', () => testbed.run(() async {
// _setupMocks();
// final Completer<DebugConnectionInfo> connectionInfoCompleter = Completer<DebugConnectionInfo>();
// unawaited(residentWebRunner.run(
// connectionInfoCompleter: connectionInfoCompleter,
// ));
// await connectionInfoCompleter.future;
// when(mockVmService.callServiceExtension('fullReload')).thenAnswer((Invocation _) async {
// return Response.parse(<String, Object>{'type': 'Failed'});
// });
// final OperationResult result = await residentWebRunner.restart(fullRestart: true);
test('Fails non-fatally on vmservice response error for hot restart', () => testbed.run(() async {
_setupMocks();
final Completer<DebugConnectionInfo> connectionInfoCompleter = Completer<DebugConnectionInfo>();
unawaited(residentWebRunner.run(
connectionInfoCompleter: connectionInfoCompleter,
));
await connectionInfoCompleter.future;
when(mockVmService.callMethod('hotRestart')).thenAnswer((Invocation _) async {
return Response.parse(<String, Object>{'type': 'Failed'});
});
final OperationResult result = await residentWebRunner.restart(fullRestart: false);
// expect(result.code, 1);
// expect(result.message, contains('Failed'));
// }));
expect(result.code, 0);
}));
// TODO(jonahwilliams): re-enable tests once we switch back to DWDS for hot reload/restart.
// test('Fails on vmservice response error for hot reload', () => testbed.run(() async {
// _setupMocks();
// final Completer<DebugConnectionInfo> connectionInfoCompleter = Completer<DebugConnectionInfo>();
// unawaited(residentWebRunner.run(
// connectionInfoCompleter: connectionInfoCompleter,
// ));
// await connectionInfoCompleter.future;
// when(mockVmService.callServiceExtension('hotRestart')).thenAnswer((Invocation _) async {
// return Response.parse(<String, Object>{'type': 'Failed'});
// });
// final OperationResult result = await residentWebRunner.restart(fullRestart: false);
test('Fails fatally on vmservice RpcError', () => testbed.run(() async {
_setupMocks();
final Completer<DebugConnectionInfo> connectionInfoCompleter = Completer<DebugConnectionInfo>();
unawaited(residentWebRunner.run(
connectionInfoCompleter: connectionInfoCompleter,
));
await connectionInfoCompleter.future;
when(mockVmService.callMethod('hotRestart')).thenThrow(RPCError('Something went wrong', 2, '123'));
final OperationResult result = await residentWebRunner.restart(fullRestart: false);
// expect(result.code, 1);
// expect(result.message, contains('Failed'));
// }));
expect(result.code, 1);
expect(result.message, contains('Something went wrong'));
}));
// TODO(jonahwilliams): re-enable tests once we switch back to DWDS for hot reload/restart.
// test('Fails on vmservice RpcError', () => testbed.run(() async {
// _setupMocks();
// final Completer<DebugConnectionInfo> connectionInfoCompleter = Completer<DebugConnectionInfo>();
// unawaited(residentWebRunner.run(
// connectionInfoCompleter: connectionInfoCompleter,
// ));
// await connectionInfoCompleter.future;
// when(mockVmService.callServiceExtension('hotRestart')).thenThrow(RPCError('', 2, '123'));
// final OperationResult result = await residentWebRunner.restart(fullRestart: false);
test('Fails fatally on vmservice WipError', () => testbed.run(() async {
_setupMocks();
final Completer<DebugConnectionInfo> connectionInfoCompleter = Completer<DebugConnectionInfo>();
unawaited(residentWebRunner.run(
connectionInfoCompleter: connectionInfoCompleter,
));
await connectionInfoCompleter.future;
when(mockVmService.callMethod('hotRestart')).thenThrow(WipError(<String, String>{}));
final OperationResult result = await residentWebRunner.restart(fullRestart: false);
// expect(result.code, 1);
// expect(result.message, contains('Page requires refresh'));
// }));
expect(result.code, 1);
}));
test('Fails fatally on vmservice Exception', () => testbed.run(() async {
_setupMocks();
final Completer<DebugConnectionInfo> connectionInfoCompleter = Completer<DebugConnectionInfo>();
unawaited(residentWebRunner.run(
connectionInfoCompleter: connectionInfoCompleter,
));
await connectionInfoCompleter.future;
when(mockVmService.callMethod('hotRestart')).thenThrow(Exception('Something went wrong'));
final OperationResult result = await residentWebRunner.restart(fullRestart: false);
expect(result.code, 1);
expect(result.message, contains('Something went wrong'));
}));
test('printHelp without details has web warning', () => testbed.run(() async {
residentWebRunner.printHelp(details: false);