From b4219783bbe83f31a4e175b7752ea7f69e2e2d46 Mon Sep 17 00:00:00 2001 From: Kaylee Lubick Date: Wed, 11 Jun 2025 07:36:04 -0700 Subject: [PATCH] Use pathops module groups (#169857) Skia is moving its [pathops code around](http://review.skia.org/999760). In http://review.skia.org/1001216 we added a new set of filegroups to facilitate this. This updates the BUILD.gn rules to use those new groups. ## Pre-launch Checklist - [ x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ x ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ x ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ x ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ x ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ x ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ x ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- engine/src/flutter/skia/BUILD.gn | 3 +++ 1 file changed, 3 insertions(+) diff --git a/engine/src/flutter/skia/BUILD.gn b/engine/src/flutter/skia/BUILD.gn index 522d2f42ad9..62599cdc7f0 100644 --- a/engine/src/flutter/skia/BUILD.gn +++ b/engine/src/flutter/skia/BUILD.gn @@ -7,6 +7,7 @@ _skia_root = "//flutter/third_party/skia" import("$_skia_root/gn/shared_sources.gni") import("$_skia_root/gn/skia.gni") import("$_skia_root/gn/toolchain/wasm.gni") +import("$_skia_root/modules/pathops/pathops.gni") import("flutter_defines.gni") if (is_fuchsia) { @@ -657,6 +658,7 @@ skia_component("skia") { public += skia_utils_public public += skia_effects_public public += skia_effects_imagefilter_public + public += skia_pathops_public sources = [] sources += skia_core_sources @@ -670,6 +672,7 @@ skia_component("skia") { sources += skia_encode_srcs sources += skia_sksl_core_sources sources += skia_sksl_core_module_sources + sources += skia_pathops_sources sources += skia_ports_sources sources += [ "$_skia_root/src/android/SkAndroidFrameworkUtils.cpp",