From b0300e2fc2750971f116a1578f39159bb274cf6a Mon Sep 17 00:00:00 2001 From: Mouad Debbar Date: Thu, 28 Mar 2024 15:31:14 -0400 Subject: [PATCH] Prevent `solo: true` from being committed (flutter/engine#51712) At some point, we inherited a change from the repo-level `analysis_options.yaml` that [allowed deprecated](https://github.com/flutter/engine/pull/50575) members to be used. We rely on that analyzer error to prevent `solo: true` from being committed in our tests ([example](https://github.com/flutter/engine/blob/c935c3ba364330966fda677d7d39c80c34d3ef5d/lib/web_ui/test/ui/line_metrics_test.dart#L179) of one that slipped recently). This PR overrides the `deprecated_member_use` error to enable it inside the web engine. --- engine/src/flutter/lib/web_ui/analysis_options.yaml | 6 ++++++ engine/src/flutter/lib/web_ui/dev/test_platform.dart | 1 + 2 files changed, 7 insertions(+) diff --git a/engine/src/flutter/lib/web_ui/analysis_options.yaml b/engine/src/flutter/lib/web_ui/analysis_options.yaml index 383ab4d7b0e..a840680ab72 100644 --- a/engine/src/flutter/lib/web_ui/analysis_options.yaml +++ b/engine/src/flutter/lib/web_ui/analysis_options.yaml @@ -6,6 +6,12 @@ include: ../../analysis_options.yaml +analyzer: + errors: + # We need this in the web engine in order to prevent committing `solo: true` + # in tests. + deprecated_member_use: true + linter: rules: avoid_dynamic_calls: false diff --git a/engine/src/flutter/lib/web_ui/dev/test_platform.dart b/engine/src/flutter/lib/web_ui/dev/test_platform.dart index 078b18ee863..edcc4adb86d 100644 --- a/engine/src/flutter/lib/web_ui/dev/test_platform.dart +++ b/engine/src/flutter/lib/web_ui/dev/test_platform.dart @@ -22,6 +22,7 @@ import 'package:shelf_web_socket/shelf_web_socket.dart'; import 'package:skia_gold_client/skia_gold_client.dart'; import 'package:stream_channel/stream_channel.dart'; +// ignore: deprecated_member_use import 'package:test_core/backend.dart' hide Compiler; // TODO(ditman): Fix ignores when https://github.com/flutter/flutter/issues/143599 is resolved. import 'package:test_core/src/runner/environment.dart'; // ignore: implementation_imports