DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Specs: make the change callbacks all be consistently past tense ('changed')

Browse Source 
Review URL: https://codereview.chromium.org/932783004
This commit is contained in:
Hixie 2015-02-20 13:20:41 -08:00
parent 5efcc9a6d8
commit afea90b7ce
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
specs/elements.md
View File

@ -84,7 +84,7 @@ abstract class Node extends EventTarget {
// this is why insertBefore(), append(), et al, are O(N) -- the whole affected subtree is walked
// mutating the element tree from within this is strongly discouraged, since it will result in the
// callbacks being invoked while the element tree is in a different state than implied by the callbacks
external void parentChangeCallback(ParentNode oldParent, ParentNode newParent); // O(N) in descendants
external void parentChangedCallback(ParentNode oldParent, ParentNode newParent); // O(N) in descendants
// default implementation calls attached/detached
void attachedCallback() { }
void detachedCallback() { }
@ -242,7 +242,7 @@ abstract class Element extends ParentNode {
// returns the shadow root
void endTagParsedCallback() { }
void attributeChangeCallback(String name, String oldValue, String newValue) { }
void attributeChangedCallback(String name, String oldValue, String newValue) { }
// name will never be null when this is called by sky
// TODO(ianh): does a node ever need to know when it's been redistributed?
@ -261,7 +261,7 @@ class Text extends Node {
external String get value; // O(1)
external void set (String value); // O(1)
void valueChangeCallback(String oldValue, String newValue) { }
void valueChangedCallback(String oldValue, String newValue) { }
@override
Type getLayoutManager() => TextLayoutManager; // O(1)