From 118fd98351f559203a1824094c2f664502f809ee Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Wed, 26 Aug 2015 15:49:04 -0700 Subject: [PATCH] Rename layout_utils.dart to rendering_tester.dart Also, rename build_utils.dart to widget_tester.dart. These files are now named for their most commonly used classes. Finally, add a .analysis_options to silence the (intentional) analyzer warnings in append_child_test.dart. --- sky/unit/.analysis_options | 3 +++ sky/unit/test/examples/sector_layout_test.dart | 3 ++- sky/unit/test/rendering/box_test.dart | 2 +- sky/unit/test/rendering/image_test.dart | 2 +- .../rendering/{layout_utils.dart => rendering_tester.dart} | 0 sky/unit/test/rendering/shrink_wrap_test.dart | 2 +- sky/unit/test/rendering/stack_test.dart | 2 +- sky/unit/test/rendering/viewport_test.dart | 2 +- sky/unit/test/widget/align_test.dart | 2 +- sky/unit/test/widget/box_decoration_test.dart | 2 +- sky/unit/test/widget/date_picker_test.dart | 2 +- sky/unit/test/widget/global_key_test.dart | 2 +- sky/unit/test/widget/mimic_test.dart | 2 +- sky/unit/test/widget/progress_indicator_test.dart | 2 +- sky/unit/test/widget/{build_utils.dart => widget_tester.dart} | 0 15 files changed, 16 insertions(+), 12 deletions(-) create mode 100644 sky/unit/.analysis_options rename sky/unit/test/rendering/{layout_utils.dart => rendering_tester.dart} (100%) rename sky/unit/test/widget/{build_utils.dart => widget_tester.dart} (100%) diff --git a/sky/unit/.analysis_options b/sky/unit/.analysis_options new file mode 100644 index 00000000000..5b682d4d297 --- /dev/null +++ b/sky/unit/.analysis_options @@ -0,0 +1,3 @@ +analyzer: + exclude: + - 'test/engine/append_child_test.dart' diff --git a/sky/unit/test/examples/sector_layout_test.dart b/sky/unit/test/examples/sector_layout_test.dart index 1f6bedb1d03..68d2a4d996a 100644 --- a/sky/unit/test/examples/sector_layout_test.dart +++ b/sky/unit/test/examples/sector_layout_test.dart @@ -1,5 +1,6 @@ import 'package:test/test.dart'; -import '../rendering/layout_utils.dart'; + +import '../rendering/rendering_tester.dart'; import '../../../../examples/rendering/sector_layout.dart'; void main() { diff --git a/sky/unit/test/rendering/box_test.dart b/sky/unit/test/rendering/box_test.dart index 091efd1fc08..e7e1f83a266 100644 --- a/sky/unit/test/rendering/box_test.dart +++ b/sky/unit/test/rendering/box_test.dart @@ -3,7 +3,7 @@ import 'package:sky/theme/colors.dart' as colors; import 'package:sky/theme/shadows.dart'; import 'package:test/test.dart'; -import 'layout_utils.dart'; +import 'rendering_tester.dart'; void main() { test("should size to render view", () { diff --git a/sky/unit/test/rendering/image_test.dart b/sky/unit/test/rendering/image_test.dart index d87bc6e0d8e..7e2785f49c5 100644 --- a/sky/unit/test/rendering/image_test.dart +++ b/sky/unit/test/rendering/image_test.dart @@ -3,7 +3,7 @@ import 'dart:sky' as sky; import 'package:sky/rendering.dart'; import 'package:test/test.dart'; -import 'layout_utils.dart'; +import 'rendering_tester.dart'; class SquareImage implements sky.Image { int get width => 10; diff --git a/sky/unit/test/rendering/layout_utils.dart b/sky/unit/test/rendering/rendering_tester.dart similarity index 100% rename from sky/unit/test/rendering/layout_utils.dart rename to sky/unit/test/rendering/rendering_tester.dart diff --git a/sky/unit/test/rendering/shrink_wrap_test.dart b/sky/unit/test/rendering/shrink_wrap_test.dart index 510676d14e7..3322d98ee89 100644 --- a/sky/unit/test/rendering/shrink_wrap_test.dart +++ b/sky/unit/test/rendering/shrink_wrap_test.dart @@ -1,7 +1,7 @@ import 'package:sky/rendering.dart'; import 'package:test/test.dart'; -import 'layout_utils.dart'; +import 'rendering_tester.dart'; class RenderTestBox extends RenderBox { RenderTestBox(this._intrinsicDimensions); diff --git a/sky/unit/test/rendering/stack_test.dart b/sky/unit/test/rendering/stack_test.dart index 1a4ac488583..1fbdf481a2e 100644 --- a/sky/unit/test/rendering/stack_test.dart +++ b/sky/unit/test/rendering/stack_test.dart @@ -1,7 +1,7 @@ import 'package:sky/rendering.dart'; import 'package:test/test.dart'; -import 'layout_utils.dart'; +import 'rendering_tester.dart'; void main() { test('Stack can layout with top, right, bottom, left 0.0', () { diff --git a/sky/unit/test/rendering/viewport_test.dart b/sky/unit/test/rendering/viewport_test.dart index a187487600c..dcff4b2764b 100644 --- a/sky/unit/test/rendering/viewport_test.dart +++ b/sky/unit/test/rendering/viewport_test.dart @@ -1,7 +1,7 @@ import 'package:sky/rendering.dart'; import 'package:test/test.dart'; -import 'layout_utils.dart'; +import 'rendering_tester.dart'; void main() { test('Should be able to hit with negative scroll offset', () { diff --git a/sky/unit/test/widget/align_test.dart b/sky/unit/test/widget/align_test.dart index 9a636b466c0..825d329b827 100644 --- a/sky/unit/test/widget/align_test.dart +++ b/sky/unit/test/widget/align_test.dart @@ -1,7 +1,7 @@ import 'package:sky/widgets.dart'; import 'package:test/test.dart'; -import 'build_utils.dart'; +import 'widget_tester.dart'; void main() { test('Align smoke test', () { diff --git a/sky/unit/test/widget/box_decoration_test.dart b/sky/unit/test/widget/box_decoration_test.dart index 4dc850599bb..a754ee01b10 100644 --- a/sky/unit/test/widget/box_decoration_test.dart +++ b/sky/unit/test/widget/box_decoration_test.dart @@ -2,7 +2,7 @@ import 'package:sky/theme/colors.dart' as colors; import 'package:sky/widgets.dart'; import 'package:test/test.dart'; -import 'build_utils.dart'; +import 'widget_tester.dart'; void main() { test('Circles can have uniform borders', () { diff --git a/sky/unit/test/widget/date_picker_test.dart b/sky/unit/test/widget/date_picker_test.dart index 22e102c8068..cb064cf0acd 100644 --- a/sky/unit/test/widget/date_picker_test.dart +++ b/sky/unit/test/widget/date_picker_test.dart @@ -1,7 +1,7 @@ import 'package:sky/widgets.dart'; import 'package:test/test.dart'; -import 'build_utils.dart'; +import 'widget_tester.dart'; void main() { test('Can select a day', () { diff --git a/sky/unit/test/widget/global_key_test.dart b/sky/unit/test/widget/global_key_test.dart index a410e05141f..003e295e5df 100644 --- a/sky/unit/test/widget/global_key_test.dart +++ b/sky/unit/test/widget/global_key_test.dart @@ -1,7 +1,7 @@ import 'package:sky/widgets.dart'; import 'package:test/test.dart'; -import 'build_utils.dart'; +import 'widget_tester.dart'; void main() { test('Global keys notify add and remove', () { diff --git a/sky/unit/test/widget/mimic_test.dart b/sky/unit/test/widget/mimic_test.dart index 50834e7d874..55347d12157 100644 --- a/sky/unit/test/widget/mimic_test.dart +++ b/sky/unit/test/widget/mimic_test.dart @@ -1,7 +1,7 @@ import 'package:sky/widgets.dart'; import 'package:test/test.dart'; -import 'build_utils.dart'; +import 'widget_tester.dart'; void main() { test('Mimic can track tree movements', () { diff --git a/sky/unit/test/widget/progress_indicator_test.dart b/sky/unit/test/widget/progress_indicator_test.dart index 5e7ca00e7d5..462c9bcbc63 100644 --- a/sky/unit/test/widget/progress_indicator_test.dart +++ b/sky/unit/test/widget/progress_indicator_test.dart @@ -3,7 +3,7 @@ import 'package:sky/rendering.dart'; import 'package:sky/widgets.dart'; import 'package:test/test.dart'; -import 'build_utils.dart'; +import 'widget_tester.dart'; void main() { test('LinearProgressIndicator changes when its value changes', () { diff --git a/sky/unit/test/widget/build_utils.dart b/sky/unit/test/widget/widget_tester.dart similarity index 100% rename from sky/unit/test/widget/build_utils.dart rename to sky/unit/test/widget/widget_tester.dart