From af0ca978426d9a3f50227dd4a0dcdb9abc6f9b53 Mon Sep 17 00:00:00 2001 From: Kate Lovett Date: Wed, 16 Aug 2023 19:13:04 -0500 Subject: [PATCH] Fix bad pattern in 2D tests (#132709) Fixes some poor tests choices in the 2D tests that were identified in https://github.com/flutter/packages/pull/4536 --- .../widgets/two_dimensional_viewport_test.dart | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/flutter/test/widgets/two_dimensional_viewport_test.dart b/packages/flutter/test/widgets/two_dimensional_viewport_test.dart index 6cb6d025dd3..5d8f019f3f1 100644 --- a/packages/flutter/test/widgets/two_dimensional_viewport_test.dart +++ b/packages/flutter/test/widgets/two_dimensional_viewport_test.dart @@ -1514,7 +1514,7 @@ void main() { maxXIndex: 5, maxYIndex: 5, builder: (BuildContext context, ChildVicinity vicinity) { - childKeys[vicinity] = UniqueKey(); + childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey(); return SizedBox.square(key: childKeys[vicinity], dimension: 200); } ); @@ -1602,7 +1602,7 @@ void main() { maxXIndex: 5, maxYIndex: 5, builder: (BuildContext context, ChildVicinity vicinity) { - childKeys[vicinity] = UniqueKey(); + childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey(); return SizedBox.square(key: childKeys[vicinity], dimension: 200); } ); @@ -1731,7 +1731,7 @@ void main() { maxXIndex: 5, maxYIndex: 5, builder: (BuildContext context, ChildVicinity vicinity) { - childKeys[vicinity] = UniqueKey(); + childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey(); return SizedBox.square(key: childKeys[vicinity], dimension: 200); } ); @@ -1897,7 +1897,7 @@ void main() { maxXIndex: 19, maxYIndex: 19, builder: (BuildContext context, ChildVicinity vicinity) { - childKeys[vicinity] = UniqueKey(); + childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey(); return SizedBox.square( dimension: 200, child: Center( @@ -1965,7 +1965,7 @@ void main() { maxXIndex: 5, maxYIndex: 5, builder: (BuildContext context, ChildVicinity vicinity) { - childKeys[vicinity] = UniqueKey(); + childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey(); return SizedBox.square(key: childKeys[vicinity], dimension: 200); } ); @@ -2001,7 +2001,7 @@ void main() { maxXIndex: 5, maxYIndex: 5, builder: (BuildContext context, ChildVicinity vicinity) { - childKeys[vicinity] = UniqueKey(); + childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey(); return SizedBox.square(key: childKeys[vicinity], dimension: 200); } ); @@ -2119,7 +2119,7 @@ void main() { maxXIndex: 5, maxYIndex: 5, builder: (BuildContext context, ChildVicinity vicinity) { - childKeys[vicinity] = UniqueKey(); + childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey(); return SizedBox.square(key: childKeys[vicinity], dimension: 200); } );