From ae585eb12ec3c601663fb592e27aaa4fcf805e5b Mon Sep 17 00:00:00 2001 From: Adam Barth Date: Tue, 24 Nov 2015 17:44:15 -0800 Subject: [PATCH] Remove start_test This test was a bad mock-based test that hasn't ever caught a bug but has required a lot of maintenance. Currently its broken because its mock doesn't match the real interface. --- packages/flutter_tools/test/start_test.dart | 72 --------------------- 1 file changed, 72 deletions(-) delete mode 100644 packages/flutter_tools/test/start_test.dart diff --git a/packages/flutter_tools/test/start_test.dart b/packages/flutter_tools/test/start_test.dart deleted file mode 100644 index fb23cb22ad7..00000000000 --- a/packages/flutter_tools/test/start_test.dart +++ /dev/null @@ -1,72 +0,0 @@ -// Copyright 2015 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -import 'package:args/command_runner.dart'; -import 'package:mockito/mockito.dart'; -import 'package:flutter_tools/src/commands/start.dart'; -import 'package:test/test.dart'; - -import 'src/mocks.dart'; - -main() => defineTests(); - -defineTests() { - group('start', () { - test('returns 0 when Android is connected and ready to be started', () { - StartCommand command = new StartCommand(); - applyMocksToCommand(command); - MockDeviceStore mockDevices = command.devices; - - when(mockDevices.android.isConnected()).thenReturn(true); - when(mockDevices.android.isAppInstalled(any)).thenReturn(false); - when(mockDevices.android.installApp(any)).thenReturn(true); - when(mockDevices.android.startBundle(any, any)).thenReturn(true); - when(mockDevices.android.stopApp(any)).thenReturn(true); - - when(mockDevices.iOS.isConnected()).thenReturn(false); - when(mockDevices.iOS.isAppInstalled(any)).thenReturn(false); - when(mockDevices.iOS.installApp(any)).thenReturn(false); - when(mockDevices.iOS.startApp(any)).thenReturn(false); - when(mockDevices.iOS.stopApp(any)).thenReturn(false); - - when(mockDevices.iOSSimulator.isConnected()).thenReturn(false); - when(mockDevices.iOSSimulator.isAppInstalled(any)).thenReturn(false); - when(mockDevices.iOSSimulator.installApp(any)).thenReturn(false); - when(mockDevices.iOSSimulator.startApp(any)).thenReturn(false); - when(mockDevices.iOSSimulator.stopApp(any)).thenReturn(false); - - CommandRunner runner = new CommandRunner('test_flutter', '') - ..addCommand(command); - runner.run(['start', '-t', 'test/start_test.dart']).then((int code) => expect(code, equals(0))); - }); - - test('returns 0 when iOS is connected and ready to be started', () { - StartCommand command = new StartCommand(); - applyMocksToCommand(command); - MockDeviceStore mockDevices = command.devices; - - when(mockDevices.android.isConnected()).thenReturn(false); - when(mockDevices.android.isAppInstalled(any)).thenReturn(false); - when(mockDevices.android.installApp(any)).thenReturn(false); - when(mockDevices.android.startBundle(any, any)).thenReturn(false); - when(mockDevices.android.stopApp(any)).thenReturn(false); - - when(mockDevices.iOS.isConnected()).thenReturn(true); - when(mockDevices.iOS.isAppInstalled(any)).thenReturn(false); - when(mockDevices.iOS.installApp(any)).thenReturn(true); - when(mockDevices.iOS.startApp(any)).thenReturn(true); - when(mockDevices.iOS.stopApp(any)).thenReturn(false); - - when(mockDevices.iOSSimulator.isConnected()).thenReturn(false); - when(mockDevices.iOSSimulator.isAppInstalled(any)).thenReturn(false); - when(mockDevices.iOSSimulator.installApp(any)).thenReturn(false); - when(mockDevices.iOSSimulator.startApp(any)).thenReturn(false); - when(mockDevices.iOSSimulator.stopApp(any)).thenReturn(false); - - CommandRunner runner = new CommandRunner('test_flutter', '') - ..addCommand(command); - runner.run(['start']).then((int code) => expect(code, equals(0))); - }); - }); -}