DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Specs: (reverts part of recent checkin) Make appendChild, prependChild, and setChild not return the child, since that can improve perf (especially if they're actually implemented natively)

Browse Source 
Review URL: https://codereview.chromium.org/924163004
This commit is contained in:
Hixie 2015-02-13 15:48:24 -08:00
parent dfed02124c
commit ac8d930432
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
specs/elements.md
View File

@ -139,11 +139,10 @@ abstract class ParentNode extends Node {
external void _appendChild(Node node); // O(N) in number of descendants
// node must be Text or Element
Node appendChild(Node node) {
void appendChild(Node node) {
if (node is String)
node = new Text(node);
_appendChild(node);
return node;
}
void append(List nodes) {
nodes.forEach(appendChild);
@ -151,11 +150,10 @@ abstract class ParentNode extends Node {
external void _prependChild(Node node); // O(N) in number of descendants
// node must be Text or Element
Node prependChild(Node node) {
void prependChild(Node node) {
if (node is String)
node = new Text(node);
_prependChild(node);
return node;
}
void prepend(List nodes) {
// note: not implemented in terms of _prependChild()
@ -166,10 +164,9 @@ abstract class ParentNode extends Node {
}
external void removeChildren(); // O(N) in number of descendants
Node setChild(Node node) {
void setChild(Node node) {
removeChildren();
appendChild(node);
return node;
}
void setChildren(List nodes) {
removeChildren();