From a91ebca07c447c054be29254c2efa4cb54e3a3ff Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Mon, 26 Sep 2022 16:57:57 -0400 Subject: [PATCH] [Impeller] Flip the viewport on vulkan (flutter/engine#36421) --- .../src/flutter/impeller/renderer/backend/vulkan/context_vk.cc | 2 +- .../flutter/impeller/renderer/backend/vulkan/render_pass_vk.cc | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc b/engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc index 03aa9de8f66..0a6dbbc385a 100644 --- a/engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc +++ b/engine/src/flutter/impeller/renderer/backend/vulkan/context_vk.cc @@ -272,7 +272,7 @@ ContextVK::ContextVK( vk::ApplicationInfo application_info; application_info.setApplicationVersion(VK_API_VERSION_1_0); - application_info.setApiVersion(VK_API_VERSION_1_0); + application_info.setApiVersion(VK_API_VERSION_1_1); application_info.setEngineVersion(VK_API_VERSION_1_0); application_info.setPEngineName("Impeller"); application_info.setPApplicationName("Impeller"); diff --git a/engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.cc b/engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.cc index 34809b4bac8..4beb8c17413 100644 --- a/engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.cc +++ b/engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.cc @@ -342,7 +342,8 @@ void RenderPassVK::SetViewportAndScissor(const Command& command) const { {.rect = Rect::MakeSize(GetRenderTargetSize())}); vk::Viewport viewport = vk::Viewport() .setWidth(vp.rect.size.width) - .setHeight(vp.rect.size.height) + .setHeight(-vp.rect.size.height) + .setY(vp.rect.size.height) .setMinDepth(0.0f) .setMaxDepth(1.0f); command_buffer_->setViewport(0, 1, &viewport);