Add missing dependencies to framework_tests_misc_leak_tracking (#181929)

This PR adds more dependencies to the CI task
`framework_tests_misc_leak_tracking` so that it has the same
dependencies as `framework_tests_misc`.

This is to fix a consistent failure currently in the
`framework_tests_misc_leak_tracking` task about missing Android SDK:
```
00:00 +7: test\adb_test.dart: device adb startLoggingToSink calls adb
00:00 +7 -1: test\framework\browser_test.dart: BlinkTraceEvent works with Chrome 89+ isBeginMeasuredFrame
00:00 +7 -1: test\adb_test.dart: device adb startLoggingToSink calls adb [E]
  DeviceException: The ANDROID_HOME environment variable is missing. The variable must point to the Android SDK directory containing platform-tools.
  package:flutter_devicelab/framework/devices.dart 1471:5  adbPath
  package:flutter_devicelab/framework/devices.dart 784:7   AndroidDevice.startLoggingToSink
  ===== asynchronous gap ===========================
  test\adb_test.dart 257:9                                 main.<fn>.<fn>.<fn>
```

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8690761195114703281/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout?format=raw

In theory it might be enough to just add the `android_sdk` dependency,
but I also added the remaining dependencies to keep it the same as
`framework_tests_misc`, since it makes sense for the two tasks to have
identical dependencies.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
Tong Mu 2026-02-09 19:38:14 -08:00 committed by GitHub
parent 22d1572fbe
commit a693bbef1c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -5882,7 +5882,10 @@ targets:
test_timeout_secs: "3600" # 1 hour
dependencies: >-
[
{"dependency": "goldctl", "version": "git_revision:2387d6fff449587eecbb7e45b2692ca0710b63b9"}
{"dependency": "goldctl", "version": "git_revision:2387d6fff449587eecbb7e45b2692ca0710b63b9"},
{"dependency": "vs_build", "version": "version:vs2019"},
{"dependency": "open_jdk", "version": "version:21"},
{"dependency": "android_sdk", "version": "version:36v8unmodified"}
]
shard: framework_tests
subshard: misc