From 42f48b0f0e6687e254302e3cf9413874a1044df6 Mon Sep 17 00:00:00 2001 From: Hans Muller Date: Tue, 29 Sep 2015 14:17:23 -0700 Subject: [PATCH 1/2] Fix _scrollOffsetIsInBounds analayzer warning --- packages/flutter/lib/src/fn3/scrollable.dart | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/flutter/lib/src/fn3/scrollable.dart b/packages/flutter/lib/src/fn3/scrollable.dart index ae07c857f73..8e582088c27 100644 --- a/packages/flutter/lib/src/fn3/scrollable.dart +++ b/packages/flutter/lib/src/fn3/scrollable.dart @@ -126,7 +126,10 @@ abstract class ScrollableState extends State { } bool _scrollOffsetIsInBounds(double offset) { - return offset >= scrollBehavior.minScrollOffset && offset < scrollBehavior.maxScrollOffset; + if (scrollBehavior is! ExtentScrollBehavior) + return false; + ExtentScrollBehavior behavior = scrollBehavior as ExtentScrollBehavior; + return offset >= behavior.minScrollOffset && offset < behavior.maxScrollOffset; } double _alignedScrollSnapOffset(double offset) { From 02152f65fb91d517b4ce91f682821ea82caee008 Mon Sep 17 00:00:00 2001 From: Hans Muller Date: Tue, 29 Sep 2015 14:21:57 -0700 Subject: [PATCH 2/2] Fix _scrollOffsetIsInBounds analayzer warning --- packages/flutter/lib/src/fn3/scrollable.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/flutter/lib/src/fn3/scrollable.dart b/packages/flutter/lib/src/fn3/scrollable.dart index 8e582088c27..214227bbd48 100644 --- a/packages/flutter/lib/src/fn3/scrollable.dart +++ b/packages/flutter/lib/src/fn3/scrollable.dart @@ -128,7 +128,7 @@ abstract class ScrollableState extends State { bool _scrollOffsetIsInBounds(double offset) { if (scrollBehavior is! ExtentScrollBehavior) return false; - ExtentScrollBehavior behavior = scrollBehavior as ExtentScrollBehavior; + ExtentScrollBehavior behavior = scrollBehavior; return offset >= behavior.minScrollOffset && offset < behavior.maxScrollOffset; }