DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Specs: Make isNew only get set if it's not added in the same frame as the owner layout manager

Browse Source 
Review URL: https://codereview.chromium.org/817353003
This commit is contained in:
Hixie 2014-12-22 10:37:34 -08:00
parent f87209c43f
commit a2b4ed2f1a
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
specs/style.md
View File

@ -269,6 +269,8 @@ StyleNode
The types marked with * in the list above are not part of sky:core.
TODO(ianh): consider removing 'StyleValue' from these class names
```javascript
abstract class StyleNode {
abstract void markDirty();
@ -326,11 +328,11 @@ class PixelLengthStyleValue : LengthStyleValue {
Float resolve(PropertyHandle property, RenderNode node, StyleValueResolverSettings? settings = null);
}
typedef Color Float; // TODO(ianh): figure out what Color should be
typedef RawColor Float; // TODO(ianh): figure out what Color should be
class ColorStyleValue : LengthStyleValue {
constructor(StyleNode parentNode, Float red, Float green, Float blue, Float alpha);
// ... color API ...
Color resolve(PropertyHandle property, RenderNode node, StyleValueResolverSettings? settings = null);
RawColor resolve(PropertyHandle property, RenderNode node, StyleValueResolverSettings? settings = null);
}
class AbstractOpaqueStyleValue : AbstractStyleValue {
@ -500,8 +502,10 @@ rooted at the document's RenderNode.
If you come across a node that doesn't have an assigned RenderNode,
then create one, placing it in the appropriate place in the RenderTree
tree, after any nodes marked isGhost=true, with ownerLayoutManager
pointing to the parent RenderNode's layoutManager, and then, if
autoreap is false on the ownerLayoutManager, mark it "isNew".
pointing to the parent RenderNode's layoutManager, if it has one, and,
if it has one and autoreap is false on that layout manager, mark the
new node "isNew". (This means that when a node is marked isNew, the
layout manager has already laid out at least one frame.)
For each element, if the node's needsManager is true, call
getLayoutManager() on the element, and if that's not null, and if the